chrome/test/chromedriver/client/chromedriver.py - Issue 2065733002: Add a method to override the network conditions of the ChromeDriver session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/client/chromedriver.py

Issue 2065733002: Add a method to override the network conditions of the ChromeDriver session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed hard coded network values to constants. Fixed style issues. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/chromedriver/client/chromedriver.py

diff --git a/chrome/test/chromedriver/client/chromedriver.py b/chrome/test/chromedriver/client/chromedriver.py

index 4e16f0f9d9ea9c6fad9512d77cc8fe143a1547ab..ffa78fa5cf610bf9655eb31cadd4f78dcd2bfe45 100644

--- a/chrome/test/chromedriver/client/chromedriver.py

+++ b/chrome/test/chromedriver/client/chromedriver.py

@@ -409,3 +409,7 @@ class ChromeDriver(object):

def DeleteNetworkConditions(self):

self.ExecuteCommand(Command.DELETE_NETWORK_CONDITIONS)

+ def SetNetworkConnection(self, connection_type):

prasadv 2016/06/20 20:29:09 Question: What is the difference between SetNetwor

samuong 2016/06/20 21:43:23 These are different APIs to the same functionality

+ params = {'parameters': {'type': connection_type}}

+ self.ExecuteCommand(Command.SET_NETWORK_CONNECTION, params)

« no previous file with comments | « no previous file | chrome/test/chromedriver/client/command_executor.py » ('j') | chrome/test/chromedriver/session_commands.cc » ('J')