chrome/test/chromedriver/client/command_executor.py - Issue 2065733002: Add a method to override the network conditions of the ChromeDriver session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/client/command_executor.py

Issue 2065733002: Add a method to override the network conditions of the ChromeDriver session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed web_view loop in SetNetworkConnection. Fixed function names in ChromeDesktopImpl. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/chrome_desktop_impl.cc ('K') | « chrome/test/chromedriver/client/chromedriver.py ('k') | chrome/test/chromedriver/server/http_handler.cc » ('j') | chrome/test/chromedriver/test/run_py_tests.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/client/command_executor.py

diff --git a/chrome/test/chromedriver/client/command_executor.py b/chrome/test/chromedriver/client/command_executor.py

index 4d3c31458ffbec6bf3f44648528d1ac9774ee90d..a42af82af2c7c372d41303f62b4d93d07cc67764 100644

--- a/chrome/test/chromedriver/client/command_executor.py

+++ b/chrome/test/chromedriver/client/command_executor.py

@@ -146,6 +146,10 @@ class Command(object):

SET_AUTO_REPORTING = (_Method.POST, '/session/:sessionId/autoreport')

GET_SESSION_LOGS = (_Method.POST, '/logs')

STATUS = (_Method.GET, '/status')

+ GET_EMULATED_NETWORK_CONDITIONS = (

samuong 2016/06/28 23:23:40 nit: should probably call this "GET_NETWORK_CONNEC

roisinmcl 2016/06/29 17:55:13 This was mostly a placeholder for Eva's code, so I

+ _Method.GET, '/session/:sessionId/network_connection')

+ SET_NETWORK_CONNECTION = (

+ _Method.POST, '/session/:sessionId/network_connection')

# Custom Chrome commands.

IS_LOADING = (_Method.GET, '/session/:sessionId/is_loading')