chrome/test/chromedriver/chrome/chrome_desktop_impl.cc - Issue 2065733002: Add a method to override the network conditions of the ChromeDriver session.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Issue 2065733002: Add a method to override the network conditions of the ChromeDriver session. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed web_view loop in SetNetworkConnection. Fixed function names in ChromeDesktopImpl. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.h ('k') | chrome/test/chromedriver/client/chromedriver.py » ('j') | chrome/test/chromedriver/client/command_executor.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

index 30ab4213fba69ec2234e1035e1c0dfc75b7be6f8..296524adf47703efa3ff18923445df321cfb1b2f 100644

--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

@@ -201,3 +201,12 @@ Status ChromeDesktopImpl::QuitImpl() {

const base::CommandLine& ChromeDesktopImpl::command() const {

return command_;

}

+int ChromeDesktopImpl::GetNetworkConnectionValue() const {

samuong 2016/06/28 23:23:40 nit: remove "Value" suffix If you feel "GetNetwor

roisinmcl 2016/06/29 17:55:13 Done.

+ return network_connection_;

+void ChromeDesktopImpl::SetNetworkConnectionValue(

samuong 2016/06/28 23:23:40 nit: remove "Value" suffix

roisinmcl 2016/06/29 17:55:13 Done.

+ const int& network_connection) {

+ network_connection_ = network_connection;