Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2065633002: Revert of Default components to static libraries in GN build (Closed)

Created:
4 years, 6 months ago by Zhen Wang
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Default components to static libraries in GN build (patchset #15 id:280001 of https://codereview.chromium.org/2043873004/ ) Reason for revert: This CL causes Win x64 Builder (Perf) compilation error: FAILED: obj/third_party/WebKit/Source/modules/blink_modules.lib C:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x64 False lib.exe /nologo /ignore:4221 /LTCG /LTCG /LTCG /LTCG /OUT:obj/third_party/WebKit/Source/modules/blink_modules.lib @obj/third_party/WebKit/Source/modules/blink_modules.lib.rsp obj/third_party/WebKit/Source/modules/blink_modules.lib : fatal error LNK1248: image size (10061341C) exceeds maximum allowable size (FFFFFFFF) [791/850] LINK(DLL) mus_library.dll mus_library.dll.lib [792/850] LINK cc_perftests.exe ninja: build stopped: subcommand failed. Also see http://crbug.com/619606. Original issue's description: > Default components to static libraries in GN build > > Previously components would be source sets in non-component mode. Some test targets link large components in chrome but use almost none of them, and including all object files makes these links very slow. > > BUG=617837 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/3b678169f32f46b0bab203bfd0572fad1c314ab7 > Cr-Commit-Position: refs/heads/master@{#399406} TBR=jam@chromium.org,brucedawson@chromium.org,brettw@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617837 Committed: https://crrev.com/da29fd813a852c3b08db7e065b860fc0c2e64028 Cr-Commit-Position: refs/heads/master@{#399471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -34 lines) Patch
M base/BUILD.gn View 1 chunk +6 lines, -8 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +13 lines, -22 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Zhen Wang
Created Revert of Default components to static libraries in GN build
4 years, 6 months ago (2016-06-13 17:16:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065633002/1
4 years, 6 months ago (2016-06-13 17:16:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 17:17:41 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/da29fd813a852c3b08db7e065b860fc0c2e64028 Cr-Commit-Position: refs/heads/master@{#399471}
4 years, 6 months ago (2016-06-13 17:19:42 UTC) #7
Dirk Pranke
4 years, 6 months ago (2016-06-13 17:50:54 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698