chrome/browser/BUILD.gn - Issue 2065633002: Revert of Default components to static libraries in GN build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/BUILD.gn

Issue 2065633002: Revert of Default components to static libraries in GN build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/BUILD.gn

diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn

index 9125a94a40efd78adda6235339b52df89a023b92..fe59bcdfdb7e38b9c966af078ff163af8271bae7 100644

--- a/chrome/browser/BUILD.gn

+++ b/chrome/browser/BUILD.gn

@@ -1063,10 +1063,7 @@

}

# In GYP this is part of test_support_common.

-# Use a static library here because many test binaries depend on this but don't

-# require many files from it. This makes linking more efficient.

-static_library("test_support") {

+source_set("test_support") {

testonly = true

# Always include this via the main test support target.

« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | no next file » | no next file with comments »