Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2065573003: Mus: Delete unused Mandoline Surfaces code (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus: Delete unused Mandoline Surfaces code In Mandoline, we converted SurfaceIds in SurfaceDrawQuads from submitted CompositorFrames to global Window IDs to embed other mus::Window. This was useful for out of process iframes so that the embedder could securely synchronously control position, transform and clipping of the frame. This has been obviated by unguessable SurfaceIds. In an effort to remove surfaces type converters, I'm deleting this dead code. BUG=611802 TBR=ben@chromium.org Committed: https://crrev.com/4767e6f7f9e2e54033215d8952cc5931acea2a20 Cr-Commit-Position: refs/heads/master@{#399530}

Patch Set 1 #

Patch Set 2 : Fix mus_ws_unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -218 lines) Patch
M components/mus/gpu/display_compositor/compositor_frame_sink_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/surfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D components/mus/public/cpp/surfaces/custom_surface_converter.h View 1 chunk +0 lines, -35 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.h View 3 chunks +2 lines, -6 lines 0 comments Download
M components/mus/public/cpp/surfaces/surfaces_type_converters.cc View 8 chunks +8 lines, -18 lines 0 comments Download
M components/mus/ws/platform_display.cc View 4 chunks +6 lines, -24 lines 0 comments Download
M components/mus/ws/server_window_delegate.h View 1 chunk +0 lines, -11 lines 0 comments Download
M components/mus/ws/server_window_surface.h View 4 chunks +1 line, -25 lines 0 comments Download
M components/mus/ws/server_window_surface.cc View 2 chunks +1 line, -56 lines 0 comments Download
M components/mus/ws/test_server_window_delegate.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M components/mus/ws/test_server_window_delegate.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M components/mus/ws/window_server.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/mus/ws/window_server.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Fady Samuel
4 years, 6 months ago (2016-06-13 17:34:49 UTC) #2
rjkroege
lgtm
4 years, 6 months ago (2016-06-13 17:42:32 UTC) #3
Fady Samuel
+ben@ for OWNERS.
4 years, 6 months ago (2016-06-13 17:44:08 UTC) #5
Fady Samuel
Ben, I'm TBR'ing you for this code deletion.
4 years, 6 months ago (2016-06-13 18:08:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065573003/1
4 years, 6 months ago (2016-06-13 18:09:00 UTC) #9
Ben Goodger (Google)
lgtm
4 years, 6 months ago (2016-06-13 18:17:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245687)
4 years, 6 months ago (2016-06-13 18:33:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065573003/20001
4 years, 6 months ago (2016-06-13 19:36:16 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 20:52:49 UTC) #17
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 20:53:02 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 20:54:03 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4767e6f7f9e2e54033215d8952cc5931acea2a20
Cr-Commit-Position: refs/heads/master@{#399530}

Powered by Google App Engine
This is Rietveld 408576698