Expose flash playback status and volume control to content renderer

extensions/browser/extension_web_contents_observer.cc

Index: extensions/browser/extension_web_contents_observer.cc
diff --git a/extensions/browser/extension_web_contents_observer.cc b/extensions/browser/extension_web_contents_observer.cc
index 005c90da86c941626ce61112dc880309d50b76e7..75bb08f8a3468e6183e21451ef8c315c695e99de 100644
--- a/extensions/browser/extension_web_contents_observer.cc
+++ b/extensions/browser/extension_web_contents_observer.cc
@@ -180,7 +180,7 @@ bool ExtensionWebContentsObserver::OnMessageReceived(
   return handled;
 }
 
-void ExtensionWebContentsObserver::PepperInstanceCreated() {
+void ExtensionWebContentsObserver::PepperInstanceCreated(int32_t pp_instance) {
   if (GetViewType(web_contents()) == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE) {
     ProcessManager* const process_manager =
         ProcessManager::Get(browser_context_);
@@ -191,7 +191,7 @@ void ExtensionWebContentsObserver::PepperInstanceCreated() {
   }
 }
 
-void ExtensionWebContentsObserver::PepperInstanceDeleted() {
+void ExtensionWebContentsObserver::PepperInstanceDeleted(int32_t pp_instance) {

[dcheng, 2016/06/14 20:00:32]

Do we need to pass pp_instance needed here (and above)? It doesn't seem to be
used.

[Zhiqiang Zhang (Slow), 2016/06/20 19:11:54]

It is needed in a follow-up CL (2060933002), where the browser need to know
which Pepper instance has been deleted.

[dcheng, 2016/06/20 19:32:08]

OK. This CL is fine, but that one has at least one bug (it assumes that
instance_id sent by the renderer is always valid. It can get into trouble if the
renderer sends a playback started message without sending a pepper instance
created message).

I would suggest move this particular IPC change into the other CL (and getting a
security review) or merging the two CLs.

[Zhiqiang Zhang (Slow), 2016/06/21 17:19:30]

Yes, that CL is pretty rough, and there are several UX-related stuffs need to be
figured out, so I don't want to merge the two.

As you suggested, I think the Created/Deleted and Starts/Stops IPC messages
should be moved to the other CL together, so I reverted all of them except for
the SetPepperVolume one. Does this make sense to you?

   if (GetViewType(web_contents()) == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE) {
     ProcessManager* const process_manager =
         ProcessManager::Get(browser_context_);