Expose flash playback status and volume control to content renderer

extensions/browser/extension_web_contents_observer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/extension_web_contents_observer.h"
 
 #include "content/public/browser/child_process_security_policy.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
@@ skipping 162 matching lines @@
     content::RenderFrameHost* render_frame_host) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP_WITH_PARAM(
       ExtensionWebContentsObserver, message, render_frame_host)
     IPC_MESSAGE_HANDLER(ExtensionHostMsg_Request, OnRequest)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
-void ExtensionWebContentsObserver::PepperInstanceCreated() {
+void ExtensionWebContentsObserver::PepperInstanceCreated(int32_t pp_instance) {
   if (GetViewType(web_contents()) == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE) {
     ProcessManager* const process_manager =
         ProcessManager::Get(browser_context_);
     const Extension* const extension =
         process_manager->GetExtensionForWebContents(web_contents());
     if (extension)
       process_manager->IncrementLazyKeepaliveCount(extension);
   }
 }
 
-void ExtensionWebContentsObserver::PepperInstanceDeleted() {
+void ExtensionWebContentsObserver::PepperInstanceDeleted(int32_t pp_instance) {

[dcheng, 2016/06/14 20:00:32]

Do we need to pass pp_instance needed here (and above)? It doesn't seem to be
used.

[Zhiqiang Zhang (Slow), 2016/06/20 19:11:54]

It is needed in a follow-up CL (2060933002), where the browser need to know
which Pepper instance has been deleted.

[dcheng, 2016/06/20 19:32:08]

OK. This CL is fine, but that one has at least one bug (it assumes that
instance_id sent by the renderer is always valid. It can get into trouble if the
renderer sends a playback started message without sending a pepper instance
created message).

I would suggest move this particular IPC change into the other CL (and getting a
security review) or merging the two CLs.

[Zhiqiang Zhang (Slow), 2016/06/21 17:19:30]

Yes, that CL is pretty rough, and there are several UX-related stuffs need to be
figured out, so I don't want to merge the two.

As you suggested, I think the Created/Deleted and Starts/Stops IPC messages
should be moved to the other CL together, so I reverted all of them except for
the SetPepperVolume one. Does this make sense to you?

   if (GetViewType(web_contents()) == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE) {
     ProcessManager* const process_manager =
         ProcessManager::Get(browser_context_);
     const Extension* const extension =
         process_manager->GetExtensionForWebContents(web_contents());
     if (extension)
       process_manager->DecrementLazyKeepaliveCount(extension);
   }
 }
 
@@ skipping 75 matching lines @@
   // Since this is called for all existing RenderFrameHosts during the
   // ExtensionWebContentsObserver's creation, it's possible that not all hosts
   // are ready.
   // We only initialize the frame if the renderer counterpart is live; otherwise
   // we wait for the RenderFrameCreated notification.
   if (render_frame_host->IsRenderFrameLive())
     InitializeRenderFrame(render_frame_host);
 }
 
 }  // namespace extensions