Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2065503002: [builtins] Introduce proper Float64Atan and Float64Atan2 operators. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Yang, ahaas
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Introduce proper Float64Atan and Float64Atan2 operators. Import base::ieee754::atan() and base::ieee754::atan2() from fdlibm and introduce Float64Atan and Float64Atan2 TurboFan operators based on those, similar to what we already did for Float64Log and Float64Log1p. Rewrite Math.atan() and Math.atan2() as TurboFan builtin and use the operators to also inline Math.atan() and Math.atan2() into optimized TurboFan functions. R=yangguo@chromium.org BUG=v8:5086, v8:5095 Committed: https://crrev.com/89d8c57b9c3b29e7977b13f0a9eed6bd8fb6772d Cr-Commit-Position: refs/heads/master@{#36916}

Patch Set 1 #

Patch Set 2 : [WIP] Fix GCC/Win32. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+712 lines, -50 lines) Patch
M src/assembler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/assembler.cc View 3 chunks +12 lines, -2 lines 0 comments Download
M src/base/ieee754.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/base/ieee754.cc View 1 2 chunks +223 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.h View 3 chunks +6 lines, -1 line 0 comments Download
M src/builtins.cc View 2 chunks +24 lines, -7 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +23 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +8 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/counters.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/external-reference-table.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/js/math.js View 3 chunks +0 lines, -11 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M test/cctest/compiler/value-helper.h View 4 chunks +4 lines, -0 lines 0 comments Download
M test/unittests/base/ieee754-unittest.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-13 05:57:24 UTC) #1
Benedikt Meurer
Hey Yang, Next chunk of Math. Please take a look. Thanks, Benedikt Andreas: FYI (wasm ...
4 years, 6 months ago (2016-06-13 05:58:02 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065503002/1
4 years, 6 months ago (2016-06-13 05:58:18 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/18860)
4 years, 6 months ago (2016-06-13 06:03:02 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065503002/20001
4 years, 6 months ago (2016-06-13 06:40:58 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 07:01:47 UTC) #11
Yang
lgtm
4 years, 6 months ago (2016-06-13 07:03:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065503002/20001
4 years, 6 months ago (2016-06-13 07:03:16 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 07:06:57 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 07:08:25 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89d8c57b9c3b29e7977b13f0a9eed6bd8fb6772d
Cr-Commit-Position: refs/heads/master@{#36916}

Powered by Google App Engine
This is Rietveld 408576698