Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2065473002: [ieee754] Import ANSIfied msun log from FreeBSD. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ieee754] Import ANSIfied msun log from FreeBSD. Instead of manually adopting the ancient fdlibm sources, import the msun versions from FreeBSD instead, which were already adopted to ANSI C. Still under the same copyright. R=yangguo@chromium.org BUG=v8:5065, v8:5086 Committed: https://crrev.com/b01622c312acaa3b30d61a23ced87a9e7bda6540 Cr-Commit-Position: refs/heads/master@{#36913}

Patch Set 1 #

Patch Set 2 : Add typedefs for Windows. #

Patch Set 3 : Moar MSVC fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -72 lines) Patch
M src/base/ieee754.cc View 1 2 3 chunks +174 lines, -72 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (8 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-13 03:53:06 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065473002/1
4 years, 6 months ago (2016-06-13 03:53:37 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/18856) v8_win_rel_ng on ...
4 years, 6 months ago (2016-06-13 03:57:06 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065473002/20001
4 years, 6 months ago (2016-06-13 04:01:40 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/18857) v8_win_nosnap_shared_rel_ng on ...
4 years, 6 months ago (2016-06-13 04:05:31 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065473002/40001
4 years, 6 months ago (2016-06-13 04:10:49 UTC) #11
Yang
On 2016/06/13 04:10:49, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 6 months ago (2016-06-13 04:18:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065473002/40001
4 years, 6 months ago (2016-06-13 04:22:29 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-13 04:37:34 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 04:38:26 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b01622c312acaa3b30d61a23ced87a9e7bda6540
Cr-Commit-Position: refs/heads/master@{#36913}

Powered by Google App Engine
This is Rietveld 408576698