Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: test/cctest/test-api.cc

Issue 2065453002: [module] Track script "module code" status Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Extend compilation cache to recognize module code Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index e2773ef3373bed5afbbf4b0a2e7a7c5a82ba84bb..e965e9421a2ee43fae48709c0d22faeacbb46605 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -23604,6 +23604,31 @@ TEST(ScriptPositionInfo) {
CHECK(!script1->GetPositionInfo(220384, &info, script1->NO_OFFSET));
}
+TEST(ScriptIsModule) {
+ LocalContext env;
+ v8::Isolate* isolate = env->GetIsolate();
+ v8::HandleScope scope(isolate);
+ const char* url = "http://www.foo.com/foo.js";
+ v8::ScriptOrigin origin(v8_str(url), v8::Integer::New(isolate, 1));
+ v8::ScriptCompiler::Source script_source(v8_str("void 0;\n"), origin);
+ Local<Script> localScript;
+ i::Handle<i::SharedFunctionInfo> fnInfo;
+
+ localScript =
+ v8::ScriptCompiler::Compile(env.local(), &script_source).ToLocalChecked();
+ fnInfo = i::Handle<i::SharedFunctionInfo>::cast(
+ v8::Utils::OpenHandle(*localScript->GetUnboundScript()));
+ i::Handle<i::Script> globalScript(i::Script::cast(fnInfo->script()));
+ CHECK_EQ(false, globalScript->is_module());
+
+ localScript = v8::ScriptCompiler::CompileModule(env.local(), &script_source)
+ .ToLocalChecked();
+ fnInfo = i::Handle<i::SharedFunctionInfo>::cast(
+ v8::Utils::OpenHandle(*localScript->GetUnboundScript()));
+ i::Handle<i::Script> moduleScript(i::Script::cast(fnInfo->script()));
+ CHECK_EQ(true, moduleScript->is_module());
+}
+
void CheckMagicComments(Local<Script> script, const char* expected_source_url,
const char* expected_source_mapping_url) {
if (expected_source_url != NULL) {

Powered by Google App Engine
This is Rietveld 408576698