[module] Track script "module code" status

test/cctest/heap/test-heap.cc

Index: test/cctest/heap/test-heap.cc
diff --git a/test/cctest/heap/test-heap.cc b/test/cctest/heap/test-heap.cc
index 8fbe9963b1e749bf44c0474f5985c58cf0464ca9..6b8dd4a6be527e6f097da6b5a2e43141f4223c41 100644
--- a/test/cctest/heap/test-heap.cc
+++ b/test/cctest/heap/test-heap.cc
@@ -1631,7 +1631,7 @@ TEST(CompilationCacheCachingBehavior) {
   MaybeHandle<SharedFunctionInfo> info = compilation_cache->LookupScript(
       source, Handle<Object>(), 0, 0,
       v8::ScriptOriginOptions(false, true, false), native_context,
-      language_mode);
+      language_mode, false);
   CHECK(!info.is_null());
 
   // Check that the code cache entry survives at least on GC.
@@ -1642,7 +1642,7 @@ TEST(CompilationCacheCachingBehavior) {
     info = compilation_cache->LookupScript(
         source, Handle<Object>(), 0, 0,
         v8::ScriptOriginOptions(false, true, false), native_context,
-        language_mode);
+        language_mode, false);
     CHECK(!info.is_null());
   }
 
@@ -1661,7 +1661,7 @@ TEST(CompilationCacheCachingBehavior) {
   info = compilation_cache->LookupScript(
       source, Handle<Object>(), 0, 0,
       v8::ScriptOriginOptions(false, true, false), native_context,
-      language_mode);
+      language_mode, false);

[mike3, 2016/06/19 17:11:41]

Does this repetition justify a dedicated "not module" method signature? These
are just unit tests, but I'm not sure if they reflect a common use-case for
consumers.

[vogelheim, 2016/06/23 14:53:20]

IMHO, no. I'd suspect that most callers of LookupScript will need to know about
is_module anyhow.

If it's excessively burdensome in a test, I'd add a helper method in the test
file itself. I don't think that's the case here, though.

[mike3, 2016/06/25 19:31:45]

Acknowledged.

   CHECK(info.is_null());
 }