Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 2065403002: Implement close and open-in-new button. Add filename to quick view. (Closed)

Created:
4 years, 6 months ago by oka
Modified:
4 years, 6 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement close and open-in-new button. Add filename to quick view. Demo(internal): https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhV1J2VUk1RlJFX2M/view?usp=sharing BUG=613465 TEST=manually third_party/closure_compiler/run_compiler Committed: https://crrev.com/9e49fe0d8047ac92c5ca47ca576e3bcde63f0651 Cr-Commit-Position: refs/heads/master@{#399904}

Patch Set 1 #

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -14 lines) Patch
M ui/file_manager/file_manager/foreground/elements/files_metadata_box.html View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.html View 2 chunks +20 lines, -10 lines 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.js View 1 chunk +9 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/quick_view_controller.js View 1 4 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
oka
Nit
4 years, 6 months ago (2016-06-15 11:51:30 UTC) #1
oka
PTAL
4 years, 6 months ago (2016-06-15 11:54:46 UTC) #4
fukino
lgtm
4 years, 6 months ago (2016-06-15 14:20:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065403002/20001
4 years, 6 months ago (2016-06-15 14:47:32 UTC) #8
oka
On 2016/06/15 14:20:47, fukino wrote: > lgtm Thank you for the quick review.
4 years, 6 months ago (2016-06-15 14:47:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 15:51:49 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 15:52:00 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 15:53:42 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e49fe0d8047ac92c5ca47ca576e3bcde63f0651
Cr-Commit-Position: refs/heads/master@{#399904}

Powered by Google App Engine
This is Rietveld 408576698