ui/file_manager/file_manager/foreground/elements/files_quick_view.js - Issue 2065403002: Implement close and open-in-new button. Add filename to quick view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/elements/files_quick_view.js

Issue 2065403002: Implement close and open-in-new button. Add filename to quick view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/elements/files_quick_view.html ('k') | ui/file_manager/file_manager/foreground/js/file_manager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/elements/files_quick_view.js

diff --git a/ui/file_manager/file_manager/foreground/elements/files_quick_view.js b/ui/file_manager/file_manager/foreground/elements/files_quick_view.js

index 2ae1925a2ef2e1220f9a78184d95552334e0bdb8..83a89515532fb3c044300ecfa09eb1199ae1a937 100644

--- a/ui/file_manager/file_manager/foreground/elements/files_quick_view.js

+++ b/ui/file_manager/file_manager/foreground/elements/files_quick_view.js

@@ -64,5 +64,13 @@ var FilesQuickView = Polymer({

getFilesMetadataBox: function() {

return this.$['metadata-box'];

- }

+ },

+ // Client should assign the function to open the file.

+ onOpenInNewButtonTap: function(event) {},

+ onCloseButtonTap_: function(event) {

+ this.close();

+ },

});