Issue 2065383005: [css-flexbox] Fix handling of borders/padding for abspos items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2065383005: [css-flexbox] Fix handling of borders/padding for abspos items (Closed)

Created:
4 years, 6 months ago by cbiesinger

Modified:
4 years, 6 months ago

Reviewers:
szager1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

[css-flexbox] Fix handling of borders/padding for abspos items We can't use the flowAware functions for these because they are unaffected by the flex-direction. Use regular block functions instead. R=szager@chromium.org BUG=617287 Review-Url: https://codereview.chromium.org/2052243003 Cr-Commit-Position: refs/heads/master@{#399896} (cherry picked from commit 7640d892c09f7f8307648de38ca2e29a625dcc10) Committed: https://chromium.googlesource.com/chromium/src/+/10f49aac698899ab7be5e452fe73c2f7793e40f5

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -4 lines)			Patch
	A	third_party/WebKit/LayoutTests/css3/flexbox/border-and-padding-abspos.html	View		1 chunk	+91 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

cbiesinger

4 years, 6 months ago (2016-06-16 14:11:30 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
10f49aac698899ab7be5e452fe73c2f7793e40f5.