Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2065383005: [css-flexbox] Fix handling of borders/padding for abspos items (Closed)

Created:
4 years, 6 months ago by cbiesinger
Modified:
4 years, 6 months ago
Reviewers:
szager1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Fix handling of borders/padding for abspos items We can't use the flowAware functions for these because they are unaffected by the flex-direction. Use regular block functions instead. R=szager@chromium.org BUG=617287 Review-Url: https://codereview.chromium.org/2052243003 Cr-Commit-Position: refs/heads/master@{#399896} (cherry picked from commit 7640d892c09f7f8307648de38ca2e29a625dcc10) Committed: https://chromium.googlesource.com/chromium/src/+/10f49aac698899ab7be5e452fe73c2f7793e40f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/border-and-padding-abspos.html View 1 chunk +91 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
cbiesinger
4 years, 6 months ago (2016-06-16 14:11:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
10f49aac698899ab7be5e452fe73c2f7793e40f5.

Powered by Google App Engine
This is Rietveld 408576698