Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2052243003: [css-flexbox] Fix handling of borders/padding for abspos items (Closed)

Created:
4 years, 6 months ago by cbiesinger
Modified:
4 years, 6 months ago
Reviewers:
esprehn, eae, szager1
CC:
chromium-reviews, cbiesinger, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-flexbox] Fix handling of borders/padding for abspos items We can't use the flowAware functions for these because they are unaffected by the flex-direction. Use regular block functions instead. R=szager@chromium.org BUG=617287 Committed: https://crrev.com/7640d892c09f7f8307648de38ca2e29a625dcc10 Cr-Commit-Position: refs/heads/master@{#399896}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/css3/flexbox/border-and-padding-abspos.html View 1 chunk +91 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
cbiesinger
4 years, 6 months ago (2016-06-10 19:28:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052243003/1
4 years, 6 months ago (2016-06-10 19:29:29 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/237377)
4 years, 6 months ago (2016-06-10 22:35:49 UTC) #6
cbiesinger
Trying some more layout people until eae is back
4 years, 6 months ago (2016-06-14 12:52:13 UTC) #8
szager1
lgtm
4 years, 6 months ago (2016-06-15 12:30:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052243003/1
4 years, 6 months ago (2016-06-15 12:32:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 14:51:11 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 14:51:19 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 14:53:06 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7640d892c09f7f8307648de38ca2e29a625dcc10
Cr-Commit-Position: refs/heads/master@{#399896}

Powered by Google App Engine
This is Rietveld 408576698