Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2065373002: Gender-neutralize a few more comments / strings. (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 5 months ago
CC:
chromium-reviews, browser-components-watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, tfarina, dzhioev+watch_chromium.org, achuith+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, asvitkine+watch_chromium.org, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, tnagel+watch_chromium.org, davemoore+watch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gender-neutralize a few more comments / strings. BUG=none CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/993006d919c7b0d3e2309041c1e45b8d7fc7ff0e Cr-Commit-Position: refs/heads/master@{#399889}

Patch Set 1 #

Patch Set 2 : that was weird #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -54 lines) Patch
M chrome/app/bookmarks_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chromeos_strings.grdp View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/saml_interstitial.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_password_items_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_metrics.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/components_chromium_strings.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/proto/web.proto View 1 chunk +1 line, -1 line 0 comments Download
M components/metrics/proto/system_profile.proto View 2 chunks +2 lines, -2 lines 3 comments Download
M components/omnibox/browser/autocomplete_match.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/in_memory_url_index.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/omnibox_edit_model.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/omnibox/browser/omnibox_edit_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/omnibox_log.h View 1 chunk +1 line, -1 line 0 comments Download
M components/omnibox/browser/shortcuts_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 1 chunk +8 lines, -9 lines 0 comments Download
M components/policy/proto/device_management_backend.proto View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/resources/policy_templates.json View 1 8 chunks +10 lines, -10 lines 0 comments Download
M components/supervised_user_error_page_strings.grdp View 1 chunk +4 lines, -4 lines 0 comments Download
M components/user_prefs/tracked/pref_hash_store_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M docs/shift_based_development.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (8 generated)
Nico
4 years, 6 months ago (2016-06-15 09:39:19 UTC) #3
blundell
lgtm
4 years, 6 months ago (2016-06-15 11:14:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065373002/20001
4 years, 6 months ago (2016-06-15 11:40:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/200993)
4 years, 6 months ago (2016-06-15 11:46:52 UTC) #8
Nico
atwilson, can you take a look at policy_templates.json please?
4 years, 6 months ago (2016-06-15 11:49:45 UTC) #10
Andrew T Wilson (Slow)
policy_templates lgtm
4 years, 6 months ago (2016-06-15 13:35:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065373002/20001
4 years, 6 months ago (2016-06-15 13:45:46 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 13:51:40 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 13:51:52 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/993006d919c7b0d3e2309041c1e45b8d7fc7ff0e Cr-Commit-Position: refs/heads/master@{#399889}
4 years, 6 months ago (2016-06-15 13:53:18 UTC) #17
Alexei Svitkine (slow)
https://codereview.chromium.org/2065373002/diff/20001/components/metrics/proto/system_profile.proto File components/metrics/proto/system_profile.proto (left): https://codereview.chromium.org/2065373002/diff/20001/components/metrics/proto/system_profile.proto#oldcode448 components/metrics/proto/system_profile.proto:448: // and does not jump if the user changes ...
4 years, 6 months ago (2016-06-16 06:29:59 UTC) #19
Nico
https://codereview.chromium.org/2065373002/diff/20001/components/metrics/proto/system_profile.proto File components/metrics/proto/system_profile.proto (left): https://codereview.chromium.org/2065373002/diff/20001/components/metrics/proto/system_profile.proto#oldcode448 components/metrics/proto/system_profile.proto:448: // and does not jump if the user changes ...
4 years, 6 months ago (2016-06-16 13:50:43 UTC) #20
Alexei Svitkine (slow)
https://codereview.chromium.org/2065373002/diff/20001/components/metrics/proto/system_profile.proto File components/metrics/proto/system_profile.proto (left): https://codereview.chromium.org/2065373002/diff/20001/components/metrics/proto/system_profile.proto#oldcode448 components/metrics/proto/system_profile.proto:448: // and does not jump if the user changes ...
4 years, 6 months ago (2016-06-16 14:05:11 UTC) #21
Nico
Thank you! On Jun 16, 2016 4:05 PM, <asvitkine@chromium.org> wrote: > > > https://codereview.chromium.org/2065373002/diff/20001/components/metrics/proto/system_profile.proto > ...
4 years, 6 months ago (2016-06-16 14:14:24 UTC) #22
Thiemo Nagel
4 years, 5 months ago (2016-07-01 19:16:11 UTC) #23
Message was sent while issue was closed.
Thank you for doing this!

Powered by Google App Engine
This is Rietveld 408576698