Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2065363002: [Android, Video, Autoplay] Only autoplay muted videos, ignore audio tags. (Closed)

Created:
4 years, 6 months ago by whywhat
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android, Video, Autoplay] Only autoplay muted videos, ignore audio tags. Added a test for audio muted autoplay BUG=619969 TEST=manual + layout tests Committed: https://crrev.com/14b944fc8d348a17eaf24dd7a8b66662bf3d1ca8 Cr-Commit-Position: refs/heads/master@{#400149}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed setTimeout to 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/media/autoplay-muted.html View 1 2 chunks +31 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
whywhat
PTaL
4 years, 6 months ago (2016-06-15 09:21:44 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065363002/1
4 years, 6 months ago (2016-06-15 09:21:46 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-15 11:03:54 UTC) #6
mlamouri (slow - plz ping)
lgtm with test fix. Thanks! \o/ https://codereview.chromium.org/2065363002/diff/1/third_party/WebKit/LayoutTests/media/autoplay-muted.html File third_party/WebKit/LayoutTests/media/autoplay-muted.html (right): https://codereview.chromium.org/2065363002/diff/1/third_party/WebKit/LayoutTests/media/autoplay-muted.html#newcode67 third_party/WebKit/LayoutTests/media/autoplay-muted.html:67: }), 100); You ...
4 years, 6 months ago (2016-06-15 20:29:12 UTC) #7
whywhat
Changed setTimeout to 0
4 years, 6 months ago (2016-06-16 12:38:43 UTC) #8
whywhat
https://codereview.chromium.org/2065363002/diff/1/third_party/WebKit/LayoutTests/media/autoplay-muted.html File third_party/WebKit/LayoutTests/media/autoplay-muted.html (right): https://codereview.chromium.org/2065363002/diff/1/third_party/WebKit/LayoutTests/media/autoplay-muted.html#newcode67 third_party/WebKit/LayoutTests/media/autoplay-muted.html:67: }), 100); On 2016/06/15 at 20:29:12, Mounir Lamouri (very ...
4 years, 6 months ago (2016-06-16 12:39:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065363002/20001
4 years, 6 months ago (2016-06-16 12:39:57 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 14:13:21 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 14:13:24 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 14:14:44 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/14b944fc8d348a17eaf24dd7a8b66662bf3d1ca8
Cr-Commit-Position: refs/heads/master@{#400149}

Powered by Google App Engine
This is Rietveld 408576698