third_party/WebKit/Source/core/html/HTMLMediaElement.cpp - Issue 2065363002: [Android, Video, Autoplay] Only autoplay muted videos, ignore audio tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2065363002: [Android, Video, Autoplay] Only autoplay muted videos, ignore audio tags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed setTimeout to 0 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

index ed596d00d9df66b3052914fec0e6c9c47b0352e2..a73f6a0f70b68bac03cdee412eb07269ac935c11 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

@@ -3710,7 +3710,8 @@ bool HTMLMediaElement::isGestureNeededForPlayback() const

// - the flag is enabled;

// - Data Saver is not enabled;

// - Autoplay is enabled in settings;

- if (muted()

+ if (isHTMLVideoElement()

+ && muted()

&& RuntimeEnabledFeatures::autoplayMutedVideosEnabled()

&& !(document().settings() && document().settings()->dataSaverEnabled())

&& isAutoplayAllowedPerSettings()) {

« no previous file with comments | « third_party/WebKit/LayoutTests/media/autoplay-muted.html ('k') | no next file » | no next file with comments »