Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2065283002: Add heuristics to limit showing of new backspace UI bubble. (Closed)

Created:
4 years, 6 months ago by Peter Kasting
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Add heuristics to limit showing of new backspace UI bubble. This restricts the bubble to showing 5 times, and only showing when users trigger backspace twice within three seconds (which likely indicates "hey, why isn't the browser going back"). The bubble is also immediately hidden (by fading out) if the user successfully navigates back or forward (by any means) while it's showing. BUG=610039, 615760 TEST=New "press alt-left to go back" UI should not appear when pressing backspace (to attempt to go back) unless backspace is pressed twice within three seconds. After the UI is shown 5 times, it should not appear again. TBR=phajdan.jr Review-Url: https://codereview.chromium.org/2041293002 Cr-Commit-Position: refs/heads/master@{#399114} (cherry picked from commit 36aa72944195f579454c1d3abea5045219fd685a) Committed: https://chromium.googlesource.com/chromium/src/+/6895d9eea0c14482c02bb6b27e756f3fd2abdff2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -48 lines) Patch
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser_view_prefs.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.h View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm View 1 chunk +31 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 3 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +38 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/new_back_shortcut_bubble.h View 1 chunk +9 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/new_back_shortcut_bubble.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Peter Kasting
4 years, 6 months ago (2016-06-14 22:35:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6895d9eea0c14482c02bb6b27e756f3fd2abdff2.

Powered by Google App Engine
This is Rietveld 408576698