chrome/browser/ui/cocoa/browser_window_cocoa.h - Issue 2065283002: Add heuristics to limit showing of new backspace UI bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.h

Issue 2065283002: Add heuristics to limit showing of new backspace UI bubble. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/browser/exclusive_access_controller_views.mm ('k') | chrome/browser/ui/cocoa/browser_window_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_cocoa.h

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.h b/chrome/browser/ui/cocoa/browser_window_cocoa.h

index 78f16579023b91b1f4c5b96ddda71c19069d18f5..6d0a19a15a7ca445f6a1ed809d6909a13eb5d5ed 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.h

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.h

@@ -82,7 +82,8 @@ class BrowserWindowCocoa

bool ShouldHideUIForFullscreen() const override;

bool IsFullscreen() const override;

bool IsFullscreenBubbleVisible() const override;

- void ShowNewBackShortcutBubble(bool forward) override;

+ void MaybeShowNewBackShortcutBubble(bool forward) override;

+ void HideNewBackShortcutBubble() override;

LocationBar* GetLocationBar() const override;

void SetFocusToLocationBar(bool select_all) override;

void UpdateReloadStopState(bool is_loading, bool force) override;