Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2065273002:
Disable testFirstVideoPausesWhenSecondVideoStart on multi-process. (Closed)
DescriptionDisable testFirstVideoPausesWhenSecondVideoStart on Marshmallow.
It's flaky on Marshmallow tablet tester.
BUG=616575
Committed: https://crrev.com/32fc262317cfd1abc46ea9a1b4bc79b40825caa4
Cr-Commit-Position: refs/heads/master@{#399833}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Switch to disable on M #Messages
Total messages: 21 (8 generated)
mariakhomenko@chromium.org changed reviewers: + boliu@chromium.org
The CQ bit was checked by mariakhomenko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065273002/1
can we disable it only on M then? eg: https://codereview.chromium.org/2046773002
The CQ bit was unchecked by boliu@chromium.org
https://codereview.chromium.org/2065273002/diff/1/android_webview/javatests/s... File android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java (right): https://codereview.chromium.org/2065273002/diff/1/android_webview/javatests/s... android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java:46: if (CommandLine.getInstance().hasSwitch("--webview-sandboxed-renderer")) { fwiw, the correct way to make test run in single-process only is to add @ParameterizedTest.Set, without any arguments to it
On 2016/06/14 22:32:07, boliu wrote: > https://codereview.chromium.org/2065273002/diff/1/android_webview/javatests/s... > File > android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java > (right): > > https://codereview.chromium.org/2065273002/diff/1/android_webview/javatests/s... > android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java:46: > if (CommandLine.getInstance().hasSwitch("--webview-sandboxed-renderer")) { > fwiw, the correct way to make test run in single-process only is to add > @ParameterizedTest.Set, without any arguments to it Huh, haven't seen the disableif annotation before. Sure, I can just disable on M.
Description was changed from ========== Disable testFirstVideoPausesWhenSecondVideoStart on multi-process. It's flaky on Marshmallow tablet tester. BUG=616575 ========== to ========== Disable testFirstVideoPausesWhenSecondVideoStart on Marshmallow. It's flaky on Marshmallow tablet tester. BUG=616575 ==========
On 2016/06/14 22:36:05, Maria wrote: > On 2016/06/14 22:32:07, boliu wrote: > > > https://codereview.chromium.org/2065273002/diff/1/android_webview/javatests/s... > > File > > > android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java > > (right): > > > > > https://codereview.chromium.org/2065273002/diff/1/android_webview/javatests/s... > > > android_webview/javatests/src/org/chromium/android_webview/test/MultipleVideosTest.java:46: > > if (CommandLine.getInstance().hasSwitch("--webview-sandboxed-renderer")) { > > fwiw, the correct way to make test run in single-process only is to add > > @ParameterizedTest.Set, without any arguments to it > > Huh, haven't seen the disableif annotation before. Sure, I can just disable on > M. PTAL
lgtm
The CQ bit was checked by mariakhomenko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065273002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios-device-gn on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by mariakhomenko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065273002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Disable testFirstVideoPausesWhenSecondVideoStart on Marshmallow. It's flaky on Marshmallow tablet tester. BUG=616575 ========== to ========== Disable testFirstVideoPausesWhenSecondVideoStart on Marshmallow. It's flaky on Marshmallow tablet tester. BUG=616575 Committed: https://crrev.com/32fc262317cfd1abc46ea9a1b4bc79b40825caa4 Cr-Commit-Position: refs/heads/master@{#399833} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/32fc262317cfd1abc46ea9a1b4bc79b40825caa4 Cr-Commit-Position: refs/heads/master@{#399833} |
