Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2046773002: aw: Disable full screen tests on M (Closed)

Created:
4 years, 6 months ago by boliu
Modified:
4 years, 6 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Disable full screen tests on M Look to just be super flaky. Failure on different test each time. BUG=615483 Committed: https://crrev.com/026c56773f0ba0057f8b2b5a15adfa1f468c6576 Cr-Commit-Position: refs/heads/master@{#398158}

Patch Set 1 #

Patch Set 2 : @DisableIf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFullScreenTest.java View 1 17 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
boliu
syntax looks correct?
4 years, 6 months ago (2016-06-06 21:37:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046773002/1
4 years, 6 months ago (2016-06-06 21:38:27 UTC) #4
jbudorick
This disables test on L and below and _only_ runs them on M (and above). ...
4 years, 6 months ago (2016-06-06 21:47:48 UTC) #5
boliu
On 2016/06/06 21:47:48, jbudorick wrote: > This disables test on L and below and _only_ ...
4 years, 6 months ago (2016-06-06 21:48:31 UTC) #6
boliu
On 2016/06/06 21:48:31, boliu wrote: > On 2016/06/06 21:47:48, jbudorick wrote: > > This disables ...
4 years, 6 months ago (2016-06-06 22:03:34 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046773002/20001
4 years, 6 months ago (2016-06-06 22:10:50 UTC) #10
jbudorick
lgtm
4 years, 6 months ago (2016-06-06 22:12:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2046773002/20001
4 years, 6 months ago (2016-06-06 22:13:06 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 00:06:20 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 00:08:49 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/026c56773f0ba0057f8b2b5a15adfa1f468c6576
Cr-Commit-Position: refs/heads/master@{#398158}

Powered by Google App Engine
This is Rietveld 408576698