Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2065253002: Revert of Split the code for fetching images and for decoding images into two separate classes. Thi… (Closed)

Created:
4 years, 6 months ago by mark a. foltz
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2767
Target Ref:
refs/pending/branch-heads/2767
Project:
chromium
Visibility:
Public.

Description

Revert of Split the code for fetching images and for decoding images into two separate classes. This will all… (patchset #18 id:340001 of https://codereview.chromium.org/2045233002/ ) Reason for revert: Causing https://bugs.chromium.org/p/chromium/issues/detail?id=620000 and is ReleaseBlock-Dev. NOTREECHECKS=true NOPRESUBMIT=true NOTRY=true TBR=markusheintz Original issue's description: > Split the code for fetching images and for decoding images into two separate classes. This will allow to use common code for image URL fetching and platform specific implementations for image decoding. > > BUG=609127 > > Committed: https://crrev.com/d8513537879d4e6d452cbd66ac4c203752eab916 > Cr-Commit-Position: refs/heads/master@{#399457} TBR=treib@chromium.org,bauerb@chromium.org,blundell@chromium.org,mmenke@chromium.org,markusheintz@chromium.org BUG=609127 Review-Url: https://codereview.chromium.org/2068783003 Cr-Commit-Position: refs/heads/master@{#399765} (cherry picked from commit 8b92318ca8fbdafc79599e8bc707ad721b880b14) Committed: https://chromium.googlesource.com/chromium/src/+/36d2589da78a38870b473ee92dd565007532eaaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -388 lines) Patch
D chrome/browser/search/suggestions/image_decoder_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/search/suggestions/image_decoder_impl.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M chrome/browser/search/suggestions/image_fetcher_impl.h View 4 chunks +17 lines, -21 lines 0 comments Download
M chrome/browser/search/suggestions/image_fetcher_impl.cc View 3 chunks +26 lines, -29 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M components/image_fetcher.gypi View 1 chunk +1 line, -5 lines 0 comments Download
M components/image_fetcher/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M components/image_fetcher/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D components/image_fetcher/image_data_fetcher.h View 1 chunk +0 lines, -56 lines 0 comments Download
D components/image_fetcher/image_data_fetcher.cc View 1 chunk +0 lines, -101 lines 0 comments Download
D components/image_fetcher/image_decoder.h View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mark a. foltz
4 years, 6 months ago (2016-06-14 21:35:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
36d2589da78a38870b473ee92dd565007532eaaa.

Powered by Google App Engine
This is Rietveld 408576698