Revert of Split the code for fetching images and for decoding images into two separate classes.

Revert of Split the code for fetching images and for decoding images into two separate classes. This will all… (patchset #18 id:340001 of https://codereview.chromium.org/2045233002/ )

Reason for revert:
Causing https://bugs.chromium.org/p/chromium/issues/detail?id=620000 and is ReleaseBlock-Dev.

NOTREECHECKS=true
NOPRESUBMIT=true
NOTRY=true
TBR=markusheintz

Original issue's description:
> Split the code for fetching images and for decoding images into two separate classes. This will allow to use common code for image URL fetching and platform specific implementations for image decoding.
>
> BUG=609127
>
> Committed: https://crrev.com/d8513537879d4e6d452cbd66ac4c203752eab916
> Cr-Commit-Position: refs/heads/master@{#399457}

TBR=treib@chromium.org,bauerb@chromium.org,blundell@chromium.org,mmenke@chromium.org,markusheintz@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=609127
Committed: https://crrev.com/8b92318ca8fbdafc79599e8bc707ad721b880b14
Cr-Commit-Position: refs/heads/master@{#399765}

[mark a. foltz, 2016-06-14 19:05:19]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2016-06-14 19:05:19]

Created Revert of Split the code for fetching images and for decoding images
into two separate classes. This will all…

[mark a. foltz, 2016-06-14 19:06:23]

The CQ bit was unchecked by mfoltz@chromium.org

[commit-bot: I haz the power, 2016-06-14 19:06:36]

The CQ bit was unchecked by commit-bot@chromium.org

[mark a. foltz, 2016-06-14 19:06:46]

Description was changed from

==========
Revert of Split the code for fetching images and for decoding images into two
separate classes. This will all… (patchset #18 id:340001 of
https://codereview.chromium.org/2045233002/ )

Reason for revert:
Causing https://bugs.chromium.org/p/chromium/issues/detail?id=620000 and is
ReleaseBlock-Dev.

NOTREECHECKS=true
NOPRESUBMIT=true
NOTRY=true
TBR=markusheintz


Original issue's description:
> Split the code for fetching images and for decoding images into two separate
classes. This will allow to use common code for image URL fetching and platform
specific implementations for image decoding.
> 
> BUG=609127
> 
> Committed: https://crrev.com/d8513537879d4e6d452cbd66ac4c203752eab916
> Cr-Commit-Position: refs/heads/master@{#399457}

TBR=treib@chromium.org,bauerb@chromium.org,blundell@chromium.org,mmenke@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=609127
==========

to

==========
Revert of Split the code for fetching images and for decoding images into two
separate classes. This will all… (patchset #18 id:340001 of
https://codereview.chromium.org/2045233002/ )

Reason for revert:
Causing https://bugs.chromium.org/p/chromium/issues/detail?id=620000 and is
ReleaseBlock-Dev.

BUG=620000
NOTREECHECKS=true
NOPRESUBMIT=true
NOTRY=true
TBR=markusheintz


Original issue's description:
> Split the code for fetching images and for decoding images into two separate
classes. This will allow to use common code for image URL fetching and platform
specific implementations for image decoding.
> 
> BUG=609127
> 
> Committed: https://crrev.com/d8513537879d4e6d452cbd66ac4c203752eab916
> Cr-Commit-Position: refs/heads/master@{#399457}

TBR=treib@chromium.org,bauerb@chromium.org,blundell@chromium.org,mmenke@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=609127
==========

[mark a. foltz, 2016-06-14 19:06:49]

The CQ bit was checked by mfoltz@chromium.org

[commit-bot: I haz the power, 2016-06-14 19:07:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2068783003/1

[commit-bot: I haz the power, 2016-06-14 19:07:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 19:07:44]

Failed to apply patch for chrome/chrome_browser.gypi:
While running git apply --index -3 -p1;
  error: patch failed: chrome/chrome_browser.gypi:571
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: chrome/chrome_browser.gypi: patch does not apply

Patch:       chrome/chrome_browser.gypi
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index
5a96ba61459ed7833f45f6984fdd5a0b2f9d2632..ef23f287a77b53a6bc8e74b8a5a0c31101a7ab60
100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -571,8 +571,6 @@
       'browser/search/most_visited_iframe_source.h',
       'browser/search/search.cc',
       'browser/search/search.h',
-      'browser/search/suggestions/image_decoder_impl.cc',
-      'browser/search/suggestions/image_decoder_impl.h',
       'browser/search/suggestions/image_fetcher_impl.cc',
       'browser/search/suggestions/image_fetcher_impl.h',
       'browser/search/suggestions/suggestions_service_factory.cc',
@@ -3346,7 +3344,6 @@
             '../components/components.gyp:flags_ui',
             '../components/components.gyp:guest_view_browser',
             '../components/components.gyp:history_content_browser',
-            '../components/components.gyp:image_fetcher',
             '../components/components.gyp:keyed_service_content',
             '../components/components.gyp:metrics_gpu',
             '../components/components.gyp:metrics_profiler',

[commit-bot: I haz the power, 2016-06-14 19:08:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 19:08:02]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 19:09:47]

Description was changed from

==========
Revert of Split the code for fetching images and for decoding images into two
separate classes. This will all… (patchset #18 id:340001 of
https://codereview.chromium.org/2045233002/ )

Reason for revert:
Causing https://bugs.chromium.org/p/chromium/issues/detail?id=620000 and is
ReleaseBlock-Dev.

BUG=620000
NOTREECHECKS=true
NOPRESUBMIT=true
NOTRY=true
TBR=markusheintz


Original issue's description:
> Split the code for fetching images and for decoding images into two separate
classes. This will allow to use common code for image URL fetching and platform
specific implementations for image decoding.
> 
> BUG=609127
> 
> Committed: https://crrev.com/d8513537879d4e6d452cbd66ac4c203752eab916
> Cr-Commit-Position: refs/heads/master@{#399457}

TBR=treib@chromium.org,bauerb@chromium.org,blundell@chromium.org,mmenke@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=609127
==========

to

==========
Revert of Split the code for fetching images and for decoding images into two
separate classes. This will all… (patchset #18 id:340001 of
https://codereview.chromium.org/2045233002/ )

Reason for revert:
Causing https://bugs.chromium.org/p/chromium/issues/detail?id=620000 and is
ReleaseBlock-Dev.

NOTREECHECKS=true
NOPRESUBMIT=true
NOTRY=true
TBR=markusheintz

Original issue's description:
> Split the code for fetching images and for decoding images into two separate
classes. This will allow to use common code for image URL fetching and platform
specific implementations for image decoding.
>
> BUG=609127
>
> Committed: https://crrev.com/d8513537879d4e6d452cbd66ac4c203752eab916
> Cr-Commit-Position: refs/heads/master@{#399457}

TBR=treib@chromium.org,bauerb@chromium.org,blundell@chromium.org,mmenke@chrom...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=609127

Committed: https://crrev.com/8b92318ca8fbdafc79599e8bc707ad721b880b14
Cr-Commit-Position: refs/heads/master@{#399765}
==========

[commit-bot: I haz the power, 2016-06-14 19:09:48]

Patchset 1 (id:??) landed as
https://crrev.com/8b92318ca8fbdafc79599e8bc707ad721b880b14
Cr-Commit-Position: refs/heads/master@{#399765}