Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4792)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 2065243002: Placing SRT Prompt on Feedback form behind Finch feature. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
index 6e570edb81d076bbc183e29356e4369d0cca2a41..055d7b623ba0909d26e9389e838a3c4e603498d6 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
@@ -60,6 +60,10 @@ using feedback_private::SystemInformation;
using feedback_private::FeedbackInfo;
using feedback_private::FeedbackFlow;
+const base::Feature kSrtPromptOnFeedbackForm {
+ "SrtPromptOnFeedbackForm", base::FEATURE_DISABLED_BY_DEFAULT
+};
+
static base::LazyInstance<BrowserContextKeyedAPIFactory<FeedbackPrivateAPI> >
g_factory = LAZY_INSTANCE_INITIALIZER;
@@ -89,7 +93,8 @@ void FeedbackPrivateAPI::RequestFeedback(
#if defined(OS_WIN)
// Show prompt for Software Removal Tool if the Reporter component has found
// unwanted software, and the user has never run the cleaner before.
- if (safe_browsing::ReporterFoundUws() &&
+ if (base::FeatureList::IsEnabled(kSrtPromptOnFeedbackForm) &&
+ safe_browsing::ReporterFoundUws() &&
!safe_browsing::UserHasRunCleaner()) {
RequestFeedbackForFlow(description_template, category_tag, page_url,
FeedbackFlow::FEEDBACK_FLOW_SHOWSRTPROMPT);

Powered by Google App Engine
This is Rietveld 408576698