Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2065103002: Removes downgrade browser test hack and verifies renamed user data dir. (Closed)

Created:
4 years, 6 months ago by zmin
Modified:
4 years, 6 months ago
CC:
chromium-reviews, sky, chrome-enterprise-changes_google.com, Georges Khalil
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes downgrade browser test hack and verifies renamed user data dir. BUG=607592 Committed: https://crrev.com/2882e890a37185743035d0088f35a43a4cc31a9c Cr-Commit-Position: refs/heads/master@{#399811}

Patch Set 1 #

Total comments: 2

Patch Set 2 : cr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M chrome/browser/chrome_browser_main.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/downgrade/user_data_downgrade.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/downgrade/user_data_downgrade.cc View 3 chunks +5 lines, -18 lines 0 comments Download
M chrome/browser/downgrade/user_data_downgrade_browsertest.cc View 1 6 chunks +23 lines, -12 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
zmin
4 years, 6 months ago (2016-06-14 18:12:33 UTC) #3
grt (UTC plus 2)
lgtm https://codereview.chromium.org/2065103002/diff/1/chrome/browser/downgrade/user_data_downgrade_browsertest.cc File chrome/browser/downgrade/user_data_downgrade_browsertest.cc (right): https://codereview.chromium.org/2065103002/diff/1/chrome/browser/downgrade/user_data_downgrade_browsertest.cc#newcode109 chrome/browser/downgrade/user_data_downgrade_browsertest.cc:109: void SetUpInProcessBrowserTestFixture() override { nit: remove this since ...
4 years, 6 months ago (2016-06-14 18:56:50 UTC) #4
zmin
https://codereview.chromium.org/2065103002/diff/1/chrome/browser/downgrade/user_data_downgrade_browsertest.cc File chrome/browser/downgrade/user_data_downgrade_browsertest.cc (right): https://codereview.chromium.org/2065103002/diff/1/chrome/browser/downgrade/user_data_downgrade_browsertest.cc#newcode109 chrome/browser/downgrade/user_data_downgrade_browsertest.cc:109: void SetUpInProcessBrowserTestFixture() override { On 2016/06/14 18:56:49, grt (slow) ...
4 years, 6 months ago (2016-06-14 19:06:16 UTC) #5
brettw
Just did a cursory look. owners LGTM
4 years, 6 months ago (2016-06-14 21:17:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065103002/20001
4 years, 6 months ago (2016-06-14 21:19:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios-device-gn on ...
4 years, 6 months ago (2016-06-14 23:22:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065103002/20001
4 years, 6 months ago (2016-06-15 00:43:02 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 01:09:54 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 01:11:18 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2882e890a37185743035d0088f35a43a4cc31a9c
Cr-Commit-Position: refs/heads/master@{#399811}

Powered by Google App Engine
This is Rietveld 408576698