Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3450)

Unified Diff: chrome/browser/downgrade/user_data_downgrade.cc

Issue 2065103002: Removes downgrade browser test hack and verifies renamed user data dir. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cr Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/downgrade/user_data_downgrade.cc
diff --git a/chrome/browser/downgrade/user_data_downgrade.cc b/chrome/browser/downgrade/user_data_downgrade.cc
index 17dabe7a97d51e0cf1ed73097a611bb20d3b600f..be1413b74a7527ed73ac890082722b5658120ff7 100644
--- a/chrome/browser/downgrade/user_data_downgrade.cc
+++ b/chrome/browser/downgrade/user_data_downgrade.cc
@@ -31,8 +31,6 @@ namespace downgrade {
namespace {
-bool g_is_browser_test = false;
-
// Return the disk cache dir override value if exists or empty path for default
// disk cache dir.
base::FilePath GetDiskCacheDir() {
@@ -172,18 +170,11 @@ base::Version GetLastVersion(const base::FilePath& user_data_dir) {
void DeleteMovedUserDataSoon() {
base::FilePath user_data_dir;
PathService::Get(chrome::DIR_USER_DATA, &user_data_dir);
- if (g_is_browser_test) {
- // Delete task will always be posted and executed for browser test.
- content::BrowserThread::PostBlockingPoolTask(
- FROM_HERE,
- base::Bind(&DeleteMovedUserData, user_data_dir, GetDiskCacheDir()));
- } else {
- content::BrowserThread::PostAfterStartupTask(
- FROM_HERE, content::BrowserThread::GetBlockingPool()
- ->GetTaskRunnerWithShutdownBehavior(
- base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN),
- base::Bind(&DeleteMovedUserData, user_data_dir, GetDiskCacheDir()));
- }
+ content::BrowserThread::PostAfterStartupTask(
+ FROM_HERE, content::BrowserThread::GetBlockingPool()
+ ->GetTaskRunnerWithShutdownBehavior(
+ base::SequencedWorkerPool::CONTINUE_ON_SHUTDOWN),
+ base::Bind(&DeleteMovedUserData, user_data_dir, GetDiskCacheDir()));
}
bool IsMSIInstall() {
@@ -200,8 +191,4 @@ bool IsMSIInstall() {
is_msi != 0;
}
-void SetSimulateDowngradeForTest(bool is_browser_test) {
- g_is_browser_test = is_browser_test;
-}
-
} // namespace downgrade
« no previous file with comments | « chrome/browser/downgrade/user_data_downgrade.h ('k') | chrome/browser/downgrade/user_data_downgrade_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698