Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2065023002: [Media Router WebUI] Prevent error when route becomes null (Closed)

Created:
4 years, 6 months ago by btolsch
Modified:
4 years, 6 months ago
Reviewers:
apacible
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Prevent error when route becomes null Once the route-details element is stamped, getSinkForRoute_ is bound to currentRoute_. This becomes null if the route is stopped which causes getSinkForRoute_ to throw an innocuous but noisy error. This change adds a check of the route before dereferencing it. BUG=614144 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2053743002 Cr-Commit-Position: refs/heads/master@{#399281} (cherry picked from commit 16bc9a232bd6ef00891eb061687d23f77ee29efd)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
btolsch
Merging to M52, no conflicts. PTAL, thanks!
4 years, 6 months ago (2016-06-14 09:20:25 UTC) #2
apacible
rs lgtm
4 years, 6 months ago (2016-06-14 13:35:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2065023002/1
4 years, 6 months ago (2016-06-14 17:30:35 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 17:33:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698