[Media Router WebUI] Prevent error when route becomes null

[Media Router WebUI] Prevent error when route becomes null

Once the route-details element is stamped, getSinkForRoute_ is bound to
currentRoute_. This becomes null if the route is stopped which causes
getSinkForRoute_ to throw an innocuous but noisy error. This change adds
a check of the route before dereferencing it.

BUG=614144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/16bc9a232bd6ef00891eb061687d23f77ee29efd
Cr-Commit-Position: refs/heads/master@{#399281}

[btolsch, 2016-06-09 18:21:11]

Description was changed from

==========
[Media Router WebUI] Prevent error when route becomes null

Once the route-details element is stamped, getSinkForRoute_ is bound to
currentRoute_. This becomes null if the route is stopped which causes
getSinkForRoute_ to throw an innocuous but noisy error. This change adds
a check of the route before dereferencing it.

BUG=614144
==========

to

==========
[Media Router WebUI] Prevent error when route becomes null

Once the route-details element is stamped, getSinkForRoute_ is bound to
currentRoute_. This becomes null if the route is stopped which causes
getSinkForRoute_ to throw an innocuous but noisy error. This change adds
a check of the route before dereferencing it.

BUG=614144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[btolsch, 2016-06-09 18:22:21]

btolsch@chromium.org changed reviewers:
+ apacible@chromium.org

[btolsch, 2016-06-09 18:22:22]

PTAL, thanks!

[apacible, 2016-06-10 20:19:17]

https://codereview.chromium.org/2053743002/diff/1/chrome/browser/resources/me...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
(right):

https://codereview.chromium.org/2053743002/diff/1/chrome/browser/resources/me...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:1185:
return route ? this.sinkMap_[route.sinkId] : undefined;
Does this have to be undefined, or can it be null?

[btolsch, 2016-06-10 20:36:55]

https://codereview.chromium.org/2053743002/diff/1/chrome/browser/resources/me...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
(right):

https://codereview.chromium.org/2053743002/diff/1/chrome/browser/resources/me...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:1185:
return route ? this.sinkMap_[route.sinkId] : undefined;
On 2016/06/10 20:19:17, apacible wrote:
> Does this have to be undefined, or can it be null?

It can be null. Done.

[apacible, 2016-06-10 20:51:47]

lgtm

https://codereview.chromium.org/2053743002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
(right):

https://codereview.chromium.org/2053743002/diff/20001/chrome/browser/resource...
chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js:1181:
* @return {?media_router.Sink|undefined} Sink associated with |route| or
{?media_router.Sink}

[btolsch, 2016-06-10 20:55:13]

The CQ bit was checked by btolsch@chromium.org

[btolsch, 2016-06-10 20:55:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
apacible@chromium.org
Link to the patchset: https://codereview.chromium.org/2053743002/#ps40001
(title: "Remove undefined from closure type")

[commit-bot: I haz the power, 2016-06-10 20:55:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2053743002/40001

[commit-bot: I haz the power, 2016-06-10 21:48:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-10 21:48:47]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 21:51:05]

Description was changed from

==========
[Media Router WebUI] Prevent error when route becomes null

Once the route-details element is stamped, getSinkForRoute_ is bound to
currentRoute_. This becomes null if the route is stopped which causes
getSinkForRoute_ to throw an innocuous but noisy error. This change adds
a check of the route before dereferencing it.

BUG=614144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[Media Router WebUI] Prevent error when route becomes null

Once the route-details element is stamped, getSinkForRoute_ is bound to
currentRoute_. This becomes null if the route is stopped which causes
getSinkForRoute_ to throw an innocuous but noisy error. This change adds
a check of the route before dereferencing it.

BUG=614144
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/16bc9a232bd6ef00891eb061687d23f77ee29efd
Cr-Commit-Position: refs/heads/master@{#399281}
==========

[commit-bot: I haz the power, 2016-06-10 21:51:06]

Patchset 3 (id:??) landed as
https://crrev.com/16bc9a232bd6ef00891eb061687d23f77ee29efd
Cr-Commit-Position: refs/heads/master@{#399281}