Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 2064953004: [turbofan] Unify the PlainPrimitive as Number treatment. (Closed)

Created:
4 years, 6 months ago by Benedikt Meurer
Modified:
4 years, 6 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unify the PlainPrimitive as Number treatment. Now that we have the PlainPrimitiveToNumber operator(s), we can unify all the places where we expect a number, but can also safely handle any plain-primitive (via ToNumber truncation). Drive-by-fix: Also handle Math.min consistently with Math.max. R=jarin@chromium.org Committed: https://crrev.com/ed0039a72ef86d330bfa2de072dce1bf13534f13 Cr-Commit-Position: refs/heads/master@{#36984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+793 lines, -213 lines) Patch
M src/compiler/js-builtin-reducer.h View 2 chunks +8 lines, -7 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 12 chunks +142 lines, -98 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 12 chunks +16 lines, -16 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 4 chunks +44 lines, -16 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/typer.cc View 3 chunks +5 lines, -1 line 0 comments Download
M src/compiler/verifier.cc View 6 chunks +15 lines, -14 lines 0 comments Download
M src/types.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 9 chunks +535 lines, -58 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +7 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
Benedikt Meurer
4 years, 6 months ago (2016-06-15 05:05:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064953004/1
4 years, 6 months ago (2016-06-15 05:41:18 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-06-15 05:41:20 UTC) #6
Jarin
lgtm
4 years, 6 months ago (2016-06-15 05:41:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064953004/1
4 years, 6 months ago (2016-06-15 05:41:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 05:43:47 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 05:46:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed0039a72ef86d330bfa2de072dce1bf13534f13
Cr-Commit-Position: refs/heads/master@{#36984}

Powered by Google App Engine
This is Rietveld 408576698