chrome/browser/extensions/bookmark_app_helper_unittest.cc - Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/bookmark_app_helper_unittest.cc

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_manifest000 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/bookmark_app_helper_unittest.cc

diff --git a/chrome/browser/extensions/bookmark_app_helper_unittest.cc b/chrome/browser/extensions/bookmark_app_helper_unittest.cc

index 766054844cd5c9f12def3f2b2b72ac8d0cc37808..b8a2ae7bd9d28d5549fb1011adc7216f130e60a0 100644

--- a/chrome/browser/extensions/bookmark_app_helper_unittest.cc

+++ b/chrome/browser/extensions/bookmark_app_helper_unittest.cc

@@ -293,7 +293,7 @@ class TestBookmarkAppHelper : public BookmarkAppHelper {

}

void CompleteGetManifest(const content::Manifest& manifest) {

- BookmarkAppHelper::OnDidGetManifest(manifest);

+ BookmarkAppHelper::OnDidGetManifest(GURL(), manifest);

}

void CompleteIconDownload(

« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper.cc ('k') | content/browser/manifest/manifest_browsertest.cc » ('j') | no next file with comments »