Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Unified Diff: chrome/browser/extensions/bookmark_app_helper.cc

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_manifest000 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/bookmark_app_helper.cc
diff --git a/chrome/browser/extensions/bookmark_app_helper.cc b/chrome/browser/extensions/bookmark_app_helper.cc
index 24408f06aaea67170387e02b7c0bf05fc160327e..2e70bdabbb140f148ac605d63bca8e4cd5bb9bf8 100644
--- a/chrome/browser/extensions/bookmark_app_helper.cc
+++ b/chrome/browser/extensions/bookmark_app_helper.cc
@@ -571,10 +571,11 @@ void BookmarkAppHelper::CreateFromAppBanner(
DCHECK(manifest.start_url.is_valid());
callback_ = callback;
- OnDidGetManifest(manifest);
+ OnDidGetManifest(GURL(), manifest);
}
-void BookmarkAppHelper::OnDidGetManifest(const content::Manifest& manifest) {
+void BookmarkAppHelper::OnDidGetManifest(const GURL& manifest_url,
+ const content::Manifest& manifest) {
if (contents_->IsBeingDestroyed())
return;
« no previous file with comments | « chrome/browser/extensions/bookmark_app_helper.h ('k') | chrome/browser/extensions/bookmark_app_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698