chrome/browser/android/banners/app_banner_infobar_delegate_android.h - Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.h

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into webapk_manifest000 Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/banners/app_banner_data_fetcher_android.cc ('k') | chrome/browser/android/banners/app_banner_infobar_delegate_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.h

diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.h b/chrome/browser/android/banners/app_banner_infobar_delegate_android.h

index 026f4b8d784642d89811d4d41ead4c367fee760d..d036a48bf9849be5141f36f090b41dca920e543e 100644

--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.h

+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.h

@@ -34,8 +34,10 @@ class AppBannerInfoBarDelegateAndroid : public ConfirmInfoBarDelegate {

int event_request_id,

scoped_refptr<AppBannerDataFetcherAndroid> data_fetcher,

const base::string16& app_title,

+ const GURL& app_icon_url,

SkBitmap* app_icon,

- const content::Manifest& web_app_data);

+ const GURL& manifest_url,

+ const content::Manifest& manifest);

// Delegate for promoting an Android app.

AppBannerInfoBarDelegateAndroid(

@@ -83,10 +85,12 @@ class AppBannerInfoBarDelegateAndroid : public ConfirmInfoBarDelegate {

scoped_refptr<AppBannerDataFetcherAndroid> data_fetcher_;

base::string16 app_title_;

+ GURL app_icon_url_;

std::unique_ptr<SkBitmap> app_icon_;

int event_request_id_;

- content::Manifest web_app_data_;

+ GURL manifest_url_;

+ content::Manifest manifest_;

base::android::ScopedJavaGlobalRef<jobject> native_app_data_;

std::string native_app_package_;