Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: chrome/browser/android/banners/app_banner_data_fetcher_android.cc

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_manifest000 Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/banners/app_banner_data_fetcher_android.cc
diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
index b8dd12d87021e58ccb76f0cfadb1561f97822f81..10164088aa5ddfb2cfc92468681e243ffb5e2a2e 100644
--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
@@ -65,7 +65,7 @@ base::Closure AppBannerDataFetcherAndroid::FetchWebappSplashScreenImageCallback(
DCHECK(web_contents);
GURL image_url = ManifestIconSelector::FindBestMatchingIcon(
- web_app_data().icons, ideal_splash_image_size_in_dp_,
+ manifest().icons, ideal_splash_image_size_in_dp_,
minimum_splash_image_size_in_dp_);
return base::Bind(&ShortcutHelper::FetchSplashScreenImage,
@@ -73,7 +73,8 @@ base::Closure AppBannerDataFetcherAndroid::FetchWebappSplashScreenImageCallback(
minimum_splash_image_size_in_dp_, webapp_id);
}
-void AppBannerDataFetcherAndroid::ShowBanner(const SkBitmap* icon,
+void AppBannerDataFetcherAndroid::ShowBanner(const GURL& icon_url,
+ const SkBitmap* icon,
const base::string16& title,
const std::string& referrer) {
content::WebContents* web_contents = GetWebContents();
@@ -83,11 +84,11 @@ void AppBannerDataFetcherAndroid::ShowBanner(const SkBitmap* icon,
if (native_app_data_.is_null()) {
std::unique_ptr<AppBannerInfoBarDelegateAndroid> delegate(
new AppBannerInfoBarDelegateAndroid(event_request_id(), this, title,
- new SkBitmap(*icon),
- web_app_data()));
+ icon_url, new SkBitmap(*icon),
+ manifest_url(), manifest()));
infobar = new AppBannerInfoBarAndroid(std::move(delegate),
- web_app_data().start_url);
+ manifest().start_url);
if (infobar) {
RecordDidShowBanner("AppBanner.WebApp.Shown");
TrackDisplayEvent(DISPLAY_EVENT_WEB_APP_BANNER_CREATED);

Powered by Google App Engine
This is Rietveld 408576698