Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/browser/android/shortcut_info.cc

Issue 2064943002: Pass in extra parameters to WebApkBuilder#buildWebApkAsync() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into webapk_manifest Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_info.cc
diff --git a/chrome/browser/android/shortcut_info.cc b/chrome/browser/android/shortcut_info.cc
index cadec49f4dbc9a148caa01c7d869fd0a708c1396..ad2d9258233f427202ef5ae64ceec27917a88b03 100644
--- a/chrome/browser/android/shortcut_info.cc
+++ b/chrome/browser/android/shortcut_info.cc
@@ -20,6 +20,9 @@ ShortcutInfo::~ShortcutInfo() {
}
void ShortcutInfo::UpdateFromManifest(const content::Manifest& manifest) {
+ if (manifest.url.is_valid())
dominickn 2016/06/15 19:17:14 Perhaps this should be checked in the manifest par
pkotwicz 2016/06/15 20:34:24 I removed the check. You are right that manifest.u
+ manifest_url = manifest.url;
+
if (!manifest.short_name.is_null())
short_name = manifest.short_name.string();
if (!manifest.name.is_null())

Powered by Google App Engine
This is Rietveld 408576698