Pass in extra parameters to WebApkBuilder#buildWebApkAsync()

chrome/browser/android/shortcut_info.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/shortcut_info.h"
 
 ShortcutInfo::ShortcutInfo(const GURL& shortcut_url)
     : url(shortcut_url),
       display(blink::WebDisplayModeBrowser),
       orientation(blink::WebScreenOrientationLockDefault),
       source(SOURCE_ADD_TO_HOMESCREEN),
       theme_color(content::Manifest::kInvalidOrMissingColor),
       background_color(content::Manifest::kInvalidOrMissingColor),
       is_icon_generated(false) {
 }
 
 ShortcutInfo::ShortcutInfo(const ShortcutInfo& other) = default;
 
 ShortcutInfo::~ShortcutInfo() {
 }
 
 void ShortcutInfo::UpdateFromManifest(const content::Manifest& manifest) {
+  if (manifest.url.is_valid())

[dominickn, 2016/06/15 19:17:14]

Perhaps this should be checked in the manifest parser / manager? It's hard to
imagine that we could get all the way here with an invalid manifest URL.

[pkotwicz, 2016/06/15 20:34:24]

I removed the check. You are right that manifest.url should always be valid. (It
should not be possible to download the manifest from an invalid URL)

+    manifest_url = manifest.url;
+
   if (!manifest.short_name.is_null())
     short_name = manifest.short_name.string();
   if (!manifest.name.is_null())
     name = manifest.name.string();
   if (manifest.short_name.is_null() != manifest.name.is_null()) {
     if (manifest.short_name.is_null())
       short_name = name;
     else
       name = short_name;
   }
@@ skipping 26 matching lines @@
     theme_color = manifest.theme_color;
 
   // Set the background color based on the manifest value, if any.
   if (manifest.background_color != content::Manifest::kInvalidOrMissingColor)
     background_color = manifest.background_color;
 }
 
 void ShortcutInfo::UpdateSource(const Source new_source) {
   source = new_source;
 }