Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 206493002: Minor Gradient cleanup. (Closed)

Created:
6 years, 9 months ago by f(malita)
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, ed+blinkwatch_opera.com, jbroman, danakj, dglazkov+blink, Rik, apavlov+blink_chromium.org, darktears, Stephen Chennney, rune+blink, pdr., rwlbuis
Visibility:
Public.

Description

Minor Gradient cleanup. There is no need to manipulate the sorted state externally, we can efficiently detect sorted color stops on the fly. This may also avoid a sort pass in some cases. R=pdr@chromium.org,schenney@chromium.org,rob.buis@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169660

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M Source/core/css/CSSGradientValue.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/platform/graphics/Gradient.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/platform/graphics/Gradient.cpp View 1 chunk +8 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
f(malita)
6 years, 9 months ago (2014-03-20 14:10:47 UTC) #1
Stephen Chennney
LGTM
6 years, 9 months ago (2014-03-20 14:26:43 UTC) #2
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 9 months ago (2014-03-20 14:39:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/206493002/1
6 years, 9 months ago (2014-03-20 14:39:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 14:47:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-20 14:47:09 UTC) #6
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 9 months ago (2014-03-20 14:47:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/206493002/1
6 years, 9 months ago (2014-03-20 14:47:38 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 15:41:04 UTC) #9
Message was sent while issue was closed.
Change committed as 169660

Powered by Google App Engine
This is Rietveld 408576698