Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: chrome/browser/themes/theme_properties.cc

Issue 2064903003: Set bookmarks bar text color to #646464 in MD mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Set Incognito MD bookmarks bar text to #8AFFFFFF or 54% white Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/themes/theme_properties.cc
diff --git a/chrome/browser/themes/theme_properties.cc b/chrome/browser/themes/theme_properties.cc
index 770b3dd61b00654857a6631e6305a160e3272707..a03a4715b5491808f49d05b3e91eae81a1c4f248 100644
--- a/chrome/browser/themes/theme_properties.cc
+++ b/chrome/browser/themes/theme_properties.cc
@@ -88,9 +88,10 @@ const SkColor kDefaultColorBackgroundTabTextIncognito[] = {
SkColorSetRGB(0x40, 0x40, 0x40), SK_ColorWHITE};
#endif // OS_MACOSX
-constexpr SkColor kDefaultColorBookmarkText = SK_ColorBLACK;
-constexpr SkColor kDefaultColorBookmarkTextIncognito[] = {
- kDefaultColorBookmarkText, SK_ColorWHITE};
+const SkColor kDefaultColorBookmarkText[] = {
+ SK_ColorBLACK, SkColorSetRGB(0x64, 0x64, 0x64)};
Evan Stade 2016/06/14 14:40:30 won't changing this also impact the attached bar a
kylix_rd 2016/06/14 14:47:22 I've uploaded images to the bug report for comment
+const SkColor kDefaultColorBookmarkTextIncognito[] = {
+ SK_ColorBLACK, SkColorSetARGB(0x8A, 0xFF, 0xFF, 0xFF)};
#if defined(OS_WIN)
const SkColor kDefaultColorNTPBackground =
@@ -333,7 +334,7 @@ SkColor ThemeProperties::GetDefaultColor(int id, bool otr) {
: kDefaultColorBackgroundTabText[mode];
case COLOR_BOOKMARK_TEXT:
return otr ? kDefaultColorBookmarkTextIncognito[mode]
- : kDefaultColorBookmarkText;
+ : kDefaultColorBookmarkText[mode];
case COLOR_NTP_BACKGROUND:
return kDefaultColorNTPBackground;
case COLOR_NTP_TEXT:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698