Set bookmarks bar text color to #646464 in MD mode

chrome/browser/themes/theme_properties.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/themes/theme_properties.h"
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/strings/string_split.h"
@@ skipping 70 matching lines @@
                                                       SK_ColorBLACK};
 constexpr SkColor kDefaultColorBackgroundTabTextIncognito[] = {
     kDefaultColorBackgroundTabText[0], SK_ColorWHITE};
 #else
 const SkColor kDefaultColorBackgroundTabText[] = {
     SkColorSetRGB(0x40, 0x40, 0x40), SK_ColorBLACK};
 const SkColor kDefaultColorBackgroundTabTextIncognito[] = {
     SkColorSetRGB(0x40, 0x40, 0x40), SK_ColorWHITE};
 #endif  // OS_MACOSX
 
-constexpr SkColor kDefaultColorBookmarkText = SK_ColorBLACK;
-constexpr SkColor kDefaultColorBookmarkTextIncognito[] = {
-    kDefaultColorBookmarkText, SK_ColorWHITE};
+const SkColor kDefaultColorBookmarkText[] = {
+    SK_ColorBLACK, SkColorSetRGB(0x64, 0x64, 0x64)};

[Evan Stade, 2016/06/14 14:40:30]

won't changing this also impact the attached bar as well as the bookmark
buttons? The bug says "empty bookmarks bar" but doesn't specify attached vs
detached. The bg for each of these cases is different so I suspect the fg should
be different too.

The bug also doesn't say the bookmark button text should change. 

[kylix_rd, 2016/06/14 14:47:22]

I've uploaded images to the bug report for comment. To me, the text remains
readable in either mode with the same foreground color.

+const SkColor kDefaultColorBookmarkTextIncognito[] = {
+    SK_ColorBLACK, SkColorSetARGB(0x8A, 0xFF, 0xFF, 0xFF)};
 
 #if defined(OS_WIN)
 const SkColor kDefaultColorNTPBackground =
     color_utils::GetSysSkColor(COLOR_WINDOW);
 const SkColor kDefaultColorNTPText =
     color_utils::GetSysSkColor(COLOR_WINDOWTEXT);
 const SkColor kDefaultColorNTPLink = color_utils::GetSysSkColor(COLOR_HOTLIGHT);
 #else
 // TODO(beng): source from theme provider.
 constexpr SkColor kDefaultColorNTPBackground = SK_ColorWHITE;
@@ skipping 222 matching lines @@
       return otr ? kDefaultColorToolbarIncognito[mode]
                  : kDefaultColorToolbar[mode];
     case COLOR_TAB_TEXT:
       return otr ? kDefaultColorTabTextIncognito[mode]
                  : kDefaultColorTabText;
     case COLOR_BACKGROUND_TAB_TEXT:
       return otr ? kDefaultColorBackgroundTabTextIncognito[mode]
                  : kDefaultColorBackgroundTabText[mode];
     case COLOR_BOOKMARK_TEXT:
       return otr ? kDefaultColorBookmarkTextIncognito[mode]
-                 : kDefaultColorBookmarkText;
+                 : kDefaultColorBookmarkText[mode];
     case COLOR_NTP_BACKGROUND:
       return kDefaultColorNTPBackground;
     case COLOR_NTP_TEXT:
       return kDefaultColorNTPText;
     case COLOR_NTP_LINK:
       return kDefaultColorNTPLink;
     case COLOR_NTP_LINK_UNDERLINE:
       return TintForUnderline(kDefaultColorNTPLink);
     case COLOR_NTP_HEADER:
       return kDefaultColorNTPHeader;
@@ skipping 48 matching lines @@
 #endif
     case COLOR_FRAME_INCOGNITO:
     case COLOR_FRAME_INCOGNITO_INACTIVE:
       NOTREACHED() << "These values should be queried via their respective "
                       "non-incognito equivalents and an appropriate |otr| "
                       "value.";
     default:
       return gfx::kPlaceholderColor;
   }
 }