Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2064903003: Set bookmarks bar text color to #646464 in MD mode (Closed)

Created:
4 years, 6 months ago by kylix_rd
Modified:
4 years, 6 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sets bookmarks bar text color to #646464 in MD mode, per the referenced issue. BUG=566121 Committed: https://crrev.com/6b6a68db826706d2c967f44ed18a83785a97db24 Cr-Commit-Position: refs/heads/master@{#400671}

Patch Set 1 #

Patch Set 2 : Set Incognito MD bookmarks bar text to #8AFFFFFF or 54% white #

Total comments: 2

Patch Set 3 : Empty bookmarks bar text color is separate from button text color #

Patch Set 4 : When using a custom theme, defer to COLOR_BOOKMARK_TEXT #

Total comments: 1

Patch Set 5 : Punctuation nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M chrome/browser/themes/theme_properties.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/themes/theme_properties.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
kylix_rd
Currently pending final approval from sgabriel@. Should not impact any structural changes, only the actual ...
4 years, 6 months ago (2016-06-13 22:35:05 UTC) #3
kylix_rd
Normal mode color approved, waiting on approval for the Incognito mode color.
4 years, 6 months ago (2016-06-14 13:42:21 UTC) #4
Evan Stade
https://codereview.chromium.org/2064903003/diff/20001/chrome/browser/themes/theme_properties.cc File chrome/browser/themes/theme_properties.cc (right): https://codereview.chromium.org/2064903003/diff/20001/chrome/browser/themes/theme_properties.cc#newcode92 chrome/browser/themes/theme_properties.cc:92: SK_ColorBLACK, SkColorSetRGB(0x64, 0x64, 0x64)}; won't changing this also impact ...
4 years, 6 months ago (2016-06-14 14:40:30 UTC) #5
kylix_rd
https://codereview.chromium.org/2064903003/diff/20001/chrome/browser/themes/theme_properties.cc File chrome/browser/themes/theme_properties.cc (right): https://codereview.chromium.org/2064903003/diff/20001/chrome/browser/themes/theme_properties.cc#newcode92 chrome/browser/themes/theme_properties.cc:92: SK_ColorBLACK, SkColorSetRGB(0x64, 0x64, 0x64)}; On 2016/06/14 14:40:30, Evan Stade ...
4 years, 6 months ago (2016-06-14 14:47:22 UTC) #6
kylix_rd
Per the discussion on the bug, these are the proposed changes.
4 years, 6 months ago (2016-06-17 14:26:43 UTC) #7
Evan Stade
This will make it so that in the theme case, we still hardcode this color. ...
4 years, 6 months ago (2016-06-17 17:59:07 UTC) #8
kylix_rd
I think this is what we want. Initial testing seems to bear it out. With ...
4 years, 6 months ago (2016-06-17 18:18:48 UTC) #9
Evan Stade
lgtm https://codereview.chromium.org/2064903003/diff/60001/chrome/browser/themes/theme_properties.h File chrome/browser/themes/theme_properties.h (right): https://codereview.chromium.org/2064903003/diff/60001/chrome/browser/themes/theme_properties.h#newcode110 chrome/browser/themes/theme_properties.h:110: // The color of the "instructions text" in ...
4 years, 6 months ago (2016-06-17 20:23:37 UTC) #10
kylix_rd
sky@ please review small change to bookmark_bar_instruction_view.cc
4 years, 6 months ago (2016-06-17 21:10:47 UTC) #12
sky
LGTM
4 years, 6 months ago (2016-06-17 22:55:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064903003/80001
4 years, 6 months ago (2016-06-20 13:20:05 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-20 14:05:35 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 14:10:06 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6b6a68db826706d2c967f44ed18a83785a97db24
Cr-Commit-Position: refs/heads/master@{#400671}

Powered by Google App Engine
This is Rietveld 408576698