Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: mojo/public/cpp/bindings/lib/control_message_handler.cc

Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/control_message_handler.cc
diff --git a/mojo/public/cpp/bindings/lib/control_message_handler.cc b/mojo/public/cpp/bindings/lib/control_message_handler.cc
index 1bcd87daf9ef56103b30255ec0a5ce83c2fd51ad..633e95ff646d6cf293639931518bf15e7456c5fb 100644
--- a/mojo/public/cpp/bindings/lib/control_message_handler.cc
+++ b/mojo/public/cpp/bindings/lib/control_message_handler.cc
@@ -29,7 +29,7 @@ ControlMessageHandler::ControlMessageHandler(uint32_t interface_version)
ControlMessageHandler::~ControlMessageHandler() {
}
-bool ControlMessageHandler::Accept(Message* message) {
+bool ControlMessageHandler::Accept(Message* message, Error* error) {
if (message->header()->name == kRunOrClosePipeMessageId)
return RunOrClosePipe(message);
@@ -39,7 +39,8 @@ bool ControlMessageHandler::Accept(Message* message) {
bool ControlMessageHandler::AcceptWithResponder(
Message* message,
- MessageReceiverWithStatus* responder) {
+ MessageReceiverWithStatus* responder,
+ Error* error) {
if (message->header()->name == kRunMessageId)
return Run(message, responder);
@@ -64,7 +65,9 @@ bool ControlMessageHandler::Run(Message* message,
Serialize<RunResponseMessageParamsPtr>(response_params_ptr, builder.buffer(),
&response_params, &context_);
response_params->EncodePointers();
- bool ok = responder->Accept(builder.message());
+
+ Error send_error;
+ bool ok = responder->Accept(builder.message(), &send_error);
ALLOW_UNUSED_LOCAL(ok);
delete responder;

Powered by Google App Engine
This is Rietveld 408576698