mojo/public/cpp/bindings/lib/control_message_handler.h - Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/control_message_handler.h

Issue 2064903002: Mojo: Report bindings validation errors via MojoNotifyBadMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/error.h ('K') | « mojo/public/cpp/bindings/lib/connector.cc ('k') | mojo/public/cpp/bindings/lib/control_message_handler.cc » ('j') | mojo/public/cpp/bindings/message.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/lib/control_message_handler.h

diff --git a/mojo/public/cpp/bindings/lib/control_message_handler.h b/mojo/public/cpp/bindings/lib/control_message_handler.h

index 13b5aa6214ea5e08b07cc057e8638ba0f02ad0a1..2752098072eba00e54a8a1066a3f3602a3af9264 100644

--- a/mojo/public/cpp/bindings/lib/control_message_handler.h

+++ b/mojo/public/cpp/bindings/lib/control_message_handler.h

@@ -23,10 +23,11 @@ class ControlMessageHandler : public MessageReceiverWithResponderStatus {

~ControlMessageHandler() override;

// Call the following methods only if IsControlMessage() returned true.

- bool Accept(Message* message) override;

+ bool Accept(Message* message, Error* error) override;

// Takes ownership of |responder|.

bool AcceptWithResponder(Message* message,

- MessageReceiverWithStatus* responder) override;

+ MessageReceiverWithStatus* responder,

+ Error* error) override;

private:

bool Run(Message* message, MessageReceiverWithStatus* responder);