Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2064853003: Fix order of manifest_url & document_url in ParseManifestUrls() (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, Xi Han, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-manifest_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix order of manifest_url & document_url in ParseManifestUrls() BUG=619739 Committed: https://crrev.com/20e79c8a0bced8e60021f3ac04fc92391b613c65 Cr-Commit-Position: refs/heads/master@{#400986}

Patch Set 1 : Fix order of manifest_url & document_url in ParseManifestUrls() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M content/renderer/manifest/manifest_parser_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
pkotwicz
mlamouri@ can you please take a look?
4 years, 6 months ago (2016-06-14 20:50:05 UTC) #4
mlamouri (slow - plz ping)
lgtm Nice catch! :)
4 years, 6 months ago (2016-06-21 13:36:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064853003/20001
4 years, 6 months ago (2016-06-21 13:36:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 6 months ago (2016-06-21 14:27:47 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 14:31:51 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/20e79c8a0bced8e60021f3ac04fc92391b613c65
Cr-Commit-Position: refs/heads/master@{#400986}

Powered by Google App Engine
This is Rietveld 408576698