Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2322)

Unified Diff: content/renderer/manifest/manifest_parser_unittest.cc

Issue 2064853003: Fix order of manifest_url & document_url in ParseManifestUrls() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix order of manifest_url & document_url in ParseManifestUrls() Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/manifest/manifest_parser_unittest.cc
diff --git a/content/renderer/manifest/manifest_parser_unittest.cc b/content/renderer/manifest/manifest_parser_unittest.cc
index b86a0e7e6ca5c8492036ccbad00caa4b158178c7..5c4faa62440563f736f9bd89bd4fd973aa004924 100644
--- a/content/renderer/manifest/manifest_parser_unittest.cc
+++ b/content/renderer/manifest/manifest_parser_unittest.cc
@@ -29,9 +29,9 @@ class ManifestParserTest : public testing::Test {
~ManifestParserTest() override {}
Manifest ParseManifestWithURLs(const base::StringPiece& data,
- const GURL& document_url,
- const GURL& manifest_url) {
- ManifestParser parser(data, document_url, manifest_url);
+ const GURL& manifest_url,
+ const GURL& document_url) {
+ ManifestParser parser(data, manifest_url, document_url);
parser.Parse();
std::vector<ManifestDebugInfo::Error> errors;
parser.TakeErrors(&errors);
@@ -44,7 +44,7 @@ class ManifestParserTest : public testing::Test {
Manifest ParseManifest(const base::StringPiece& data) {
return ParseManifestWithURLs(
- data, default_document_url, default_manifest_url);
+ data, default_manifest_url, default_document_url);
}
const std::vector<std::string>& errors() const {
@@ -512,7 +512,7 @@ TEST_F(ManifestParserTest, IconsParseRules) {
{
Manifest manifest = ParseManifest("{ \"icons\": [ { \"src\": \"\" } ] }");
EXPECT_EQ(manifest.icons.size(), 1u);
- EXPECT_EQ(manifest.icons[0].src.spec(), "http://foo.com/index.html");
+ EXPECT_EQ(manifest.icons[0].src.spec(), "http://foo.com/manifest.json");
EXPECT_FALSE(manifest.IsEmpty());
EXPECT_EQ(0u, GetErrorCount());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698