Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2064793002: Revert of change most cases of variable redeclaration from TypeError to SyntaxError (Closed)

Created:
4 years, 6 months ago by Dan Ehrenberg
Modified:
4 years, 6 months ago
Reviewers:
jwolfe, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of change most cases of variable redeclaration from TypeError to SyntaxError (patchset #8 id:140001 of https://codereview.chromium.org/2048703002/ ) Reason for revert: This is going to break the LayoutTest inspector-protocol/console/console-let-const-with-api.html as seen in https://build.chromium.org/p/tryserver.v8/builders/v8_linux_blink_rel/builds/2247 . Please run this test manually, using instructions at https://www.chromium.org/developers/testing/webkit-layout-tests , and fix on the Chrome side if needed before resubmitting this patch. Original issue's description: > change most cases of variable redeclaration from TypeError to SyntaxError. > > Code like `let a; eval("var a;");` should throw a SyntaxError, not a TypeError > (this caused a test262 failure.). However, the code `eval("function NaN() {}");` > should actually throw a TypeError. This patch changes most cases of > redeclaration errors from TypeError to SyntaxError. See the test > mjsunit/regress/redeclaration-error-types for a thorough analysis with spec > references. > > The relevant sections of the spec are ES#sec-globaldeclarationinstantiation and > ES#sec-evaldeclarationinstantiation > > BUG=v8:4955 > LOG=y > > Committed: https://crrev.com/2b787561763d0f7e8dab698652715a742cf78291 > Cr-Commit-Position: refs/heads/master@{#36940} TBR=adamk@chromium.org,jwolfe@igalia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4955 Committed: https://crrev.com/85c2c8d8476df10464b6a6e9462ce8ab6a015ecb Cr-Commit-Position: refs/heads/master@{#36941}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -207 lines) Patch
M src/runtime/runtime-scopes.cc View 8 chunks +17 lines, -56 lines 0 comments Download
M test/mjsunit/es6/block-eval-var-over-let.js View 4 chunks +6 lines, -6 lines 0 comments Download
D test/mjsunit/regress/redeclaration-error-types.js View 1 chunk +0 lines, -145 lines 0 comments Download
M test/test262/test262.status View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dan Ehrenberg
Created Revert of change most cases of variable redeclaration from TypeError to SyntaxError
4 years, 6 months ago (2016-06-13 18:21:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064793002/1
4 years, 6 months ago (2016-06-13 18:21:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-13 18:21:58 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 18:24:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85c2c8d8476df10464b6a6e9462ce8ab6a015ecb
Cr-Commit-Position: refs/heads/master@{#36941}

Powered by Google App Engine
This is Rietveld 408576698