Add function that converts string connection type to ECT

Add function that converts string connection type to ECT

Field trials may specify the threshold ECT as a string (in
the field trial params). This function allows for easier
conversion from a string ECT to an enum ECT.

BUG=615551
Committed: https://crrev.com/75e7e4989cba8fc6a937b842955a4fb893881ed8
Cr-Commit-Position: refs/heads/master@{#400783}

[tbansal1, 2016-06-14 00:03:26]

Description was changed from

==========
Add function for converting from string connection type to ECT

BUG=615551
==========

to

==========
Add function that converts string connection type to ECT

Field trials may specify the threshold ECT as a string (in the field trial
params). This function allows for easier
conversion from a string ECT to an enum ECT.

BUG=615551
==========

[tbansal1, 2016-06-14 00:03:35]

Description was changed from

==========
Add function that converts string connection type to ECT

Field trials may specify the threshold ECT as a string (in the field trial
params). This function allows for easier
conversion from a string ECT to an enum ECT.

BUG=615551
==========

to

==========
Add function that converts string connection type to ECT

Field trials may specify the threshold ECT as a string (in
the field trial params). This function allows for easier
conversion from a string ECT to an enum ECT.

BUG=615551
==========

[tbansal1, 2016-06-14 00:03:57]

tbansal@chromium.org changed reviewers:
+ bengr@chromium.org

[tbansal1, 2016-06-14 00:03:59]

bengr: ptal. Thanks.

[bengr, 2016-06-20 14:44:16]

lgtm with nits

https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator.h (right):

https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator.h:263: // Returns a EffectiveConnectionType
equivalent to |connection_type_name|.
a -> an

https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator_unittest.cc (right):

https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1681: // Tests if the effective
connection type is converted correctly to a
if -> that

[tbansal1, 2016-06-20 20:16:35]

https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator.h (right):

https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator.h:263: // Returns a EffectiveConnectionType
equivalent to |connection_type_name|.
On 2016/06/20 14:44:16, bengr wrote:
> a -> an

Done.

https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_est...
File net/nqe/network_quality_estimator_unittest.cc (right):

https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_est...
net/nqe/network_quality_estimator_unittest.cc:1681: // Tests if the effective
connection type is converted correctly to a
On 2016/06/20 14:44:16, bengr wrote:
> if -> that

Done.

[tbansal1, 2016-06-20 20:16:38]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-06-20 20:16:38]

The patchset sent to the CQ was uploaded after l-g-t-m from bengr@chromium.org
Link to the patchset: https://codereview.chromium.org/2064763003/#ps40001
(title: "Addressed bengr comments")

[commit-bot: I haz the power, 2016-06-20 20:17:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2064763003/40001

[commit-bot: I haz the power, 2016-06-20 21:23:18]

Description was changed from

==========
Add function that converts string connection type to ECT

Field trials may specify the threshold ECT as a string (in
the field trial params). This function allows for easier
conversion from a string ECT to an enum ECT.

BUG=615551
==========

to

==========
Add function that converts string connection type to ECT

Field trials may specify the threshold ECT as a string (in
the field trial params). This function allows for easier
conversion from a string ECT to an enum ECT.

BUG=615551
==========

[commit-bot: I haz the power, 2016-06-20 21:23:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-20 21:26:13]

Description was changed from

==========
Add function that converts string connection type to ECT

Field trials may specify the threshold ECT as a string (in
the field trial params). This function allows for easier
conversion from a string ECT to an enum ECT.

BUG=615551
==========

to

==========
Add function that converts string connection type to ECT

Field trials may specify the threshold ECT as a string (in
the field trial params). This function allows for easier
conversion from a string ECT to an enum ECT.

BUG=615551

Committed: https://crrev.com/75e7e4989cba8fc6a937b842955a4fb893881ed8
Cr-Commit-Position: refs/heads/master@{#400783}
==========

[commit-bot: I haz the power, 2016-06-20 21:26:13]

Patchset 3 (id:??) landed as
https://crrev.com/75e7e4989cba8fc6a937b842955a4fb893881ed8
Cr-Commit-Position: refs/heads/master@{#400783}