Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2064763003: Add function that converts string connection type to ECT (Closed)

Created:
4 years, 6 months ago by tbansal1
Modified:
4 years, 6 months ago
Reviewers:
bengr
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add function that converts string connection type to ECT Field trials may specify the threshold ECT as a string (in the field trial params). This function allows for easier conversion from a string ECT to an enum ECT. BUG=615551 Committed: https://crrev.com/75e7e4989cba8fc6a937b842955a4fb893881ed8 Cr-Commit-Position: refs/heads/master@{#400783}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebased #

Patch Set 3 : Addressed bengr comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -5 lines) Patch
M net/nqe/network_quality_estimator.h View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M net/nqe/network_quality_estimator.cc View 2 chunks +24 lines, -1 line 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
tbansal1
bengr: ptal. Thanks.
4 years, 6 months ago (2016-06-14 00:03:59 UTC) #4
bengr
lgtm with nits https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_estimator.h File net/nqe/network_quality_estimator.h (right): https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_estimator.h#newcode263 net/nqe/network_quality_estimator.h:263: // Returns a EffectiveConnectionType equivalent to ...
4 years, 6 months ago (2016-06-20 14:44:16 UTC) #5
tbansal1
https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_estimator.h File net/nqe/network_quality_estimator.h (right): https://codereview.chromium.org/2064763003/diff/1/net/nqe/network_quality_estimator.h#newcode263 net/nqe/network_quality_estimator.h:263: // Returns a EffectiveConnectionType equivalent to |connection_type_name|. On 2016/06/20 ...
4 years, 6 months ago (2016-06-20 20:16:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064763003/40001
4 years, 6 months ago (2016-06-20 20:17:07 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-20 21:23:19 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 21:26:13 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/75e7e4989cba8fc6a937b842955a4fb893881ed8
Cr-Commit-Position: refs/heads/master@{#400783}

Powered by Google App Engine
This is Rietveld 408576698