Add function that converts string connection type to ECT

net/nqe/network_quality_estimator_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/nqe/network_quality_estimator.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <limits>
@@ skipping 1660 matching lines @@
               sign_suffix_with_one_sample + "." + interval_value + ".60_140",
           diff, 1);
       histogram_tester.ExpectTotalCount(
           "NQE.Accuracy.TransportRTT.EstimatedObservedDiff." +
               sign_suffix_with_zero_samples + "." + interval_value + ".60_140",
           0);
     }
   }
 }
 
+// Tests if the effective connection type is converted correctly to a

[bengr, 2016/06/20 14:44:16]

if -> that

[tbansal1, 2016/06/20 20:16:35]

Done.

+// descriptive string name, and vice-versa.
+TEST(NetworkQualityEstimatorTest, NameConnectionTypeConversion) {
+  for (size_t i = 0;
+       i < NetworkQualityEstimator::EFFECTIVE_CONNECTION_TYPE_LAST; ++i) {
+    const NetworkQualityEstimator::EffectiveConnectionType
+        effective_connection_type =
+            static_cast<NetworkQualityEstimator::EffectiveConnectionType>(i);
+    std::string connection_type_name =
+        std::string(NetworkQualityEstimator::GetNameForEffectiveConnectionType(
+            effective_connection_type));
+    EXPECT_FALSE(connection_type_name.empty());
+    EXPECT_EQ(effective_connection_type,
+              NetworkQualityEstimator::GetEffectiveConnectionTypeForName(
+                  connection_type_name));
+  }
+}
+
 }  // namespace net