Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2064753006: Isolate the snippet publisher string. (Closed)

Created:
4 years, 6 months ago by PEConn
Modified:
4 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, zine-eng+reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Isolate the snippet publisher string. This prevents a publisher name in a RTL/LTR language from messing up the formatting on a device set to a LTR/RTL language. BUG=608680 Committed: https://crrev.com/643221a3938e178ba7c3c6eea5314d4d7052a96a Cr-Commit-Position: refs/heads/master@{#400668}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/android/java/res/layout/new_tab_page_snippets_card.xml View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
PEConn
PTAL
4 years, 6 months ago (2016-06-15 12:34:37 UTC) #3
Bernhard Bauer
lgtm
4 years, 6 months ago (2016-06-15 15:30:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064753006/20001
4 years, 6 months ago (2016-06-20 11:15:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/23242) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-20 11:16:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2064753006/40001
4 years, 6 months ago (2016-06-20 12:49:59 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-06-20 13:37:00 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 13:38:30 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/643221a3938e178ba7c3c6eea5314d4d7052a96a
Cr-Commit-Position: refs/heads/master@{#400668}

Powered by Google App Engine
This is Rietveld 408576698