Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3771)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java

Issue 2064753006: Isolate the snippet publisher string. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_snippets_card.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
index a83941efd6b8ed4f83228220f952c64d1a24d1eb..ed965d6367162901097a54b79a5d626a97858faa 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
@@ -127,10 +127,13 @@ public class SnippetArticleViewHolder extends CardViewHolder {
mHeadlineTextView.setText(mArticle.mTitle);
- String publisherAttribution = String.format(PUBLISHER_FORMAT_STRING, mArticle.mPublisher,
+ // We format the publisher here so that having a publisher name in an RTL language doesn't
+ // mess up the formatting on an LTR device and vice versa.
+ String publisherAttribution = String.format(PUBLISHER_FORMAT_STRING,
+ BidiFormatter.getInstance().unicodeWrap(mArticle.mPublisher),
DateUtils.getRelativeTimeSpanString(mArticle.mPublishTimestampMilliseconds,
System.currentTimeMillis(), DateUtils.MINUTE_IN_MILLIS));
- mPublisherTextView.setText(BidiFormatter.getInstance().unicodeWrap(publisherAttribution));
+ mPublisherTextView.setText(publisherAttribution);
// The favicon of the publisher should match the textview height.
int widthSpec = MeasureSpec.makeMeasureSpec(0, MeasureSpec.UNSPECIFIED);
« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_snippets_card.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698